libraries: SPI: improve transaction handling#210
Draft
soburi wants to merge 2 commits into
Draft
Conversation
Since SPI<n> might be defined externally, we undefine it to avoid conflicts. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
- Use spi_transceive() for SPI transfers so TX and RX are handled as a single full-duplex operation. - Build separate 8-bit and 16-bit spi_config instances from SPISettings. - Track the last active config so endTransaction() releases the same configuration used by the transfer. Co-authored-by: kurte <kurte@rockisland.com> Co-authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
single full-duplex operation.
same configuration used by the transfer.