core: Introduce itoa.cpp#202
Open
soburi wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an Arduino-compatible integer-to-string conversion implementation to the Zephyr-based core and wires it into the core build, likely to satisfy APIs pulled in via <api/itoa.h> (and related AVR-compat helpers).
Changes:
- Added
cores/arduino/itoa.cppimplementingitoa/ltoa/utoa/ultoa(and includingdtostrf.c.impl). - Updated
cores/arduino/CMakeLists.txtto compile the new source file as part of the core.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cores/arduino/itoa.cpp | Introduces itoa/ltoa/utoa/ultoa implementations and pulls in dtostrf implementation. |
| cores/arduino/CMakeLists.txt | Adds itoa.cpp to the Zephyr core sources list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Luca Burelli <l.burelli@arduino.cc> Co-authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.