Repository navigation
Preserve backend failures in transparent and transaction RPCs - #607
Draft
skazistp-cpu wants to merge 3 commits into
Draft
skazistp-cpu wants to merge 3 commits into
skazistp-cpu wants to merge 3 commits into
Conversation
Author
|
Validation and AI review for
Independent AI helper Lagertha supplied the |
Use a non-OK fallback for unclassified balance and UTXO backend errors. Otherwise gRPC turns failed lookups into successful empty results. Cover unary and streaming methods over an in-memory gRPC transport. AI-Agent: Jarvis Co-Authored-By: OpenAI Codex (ChatGPT Astra 6) <noreply@openai.com>
AI-Agent: Jarvis Co-Authored-By: OpenAI Codex (ChatGPT Astra 6) <noreply@openai.com>
Co-Authored-By: OpenAI Codex (ChatGPT Astra 6) <noreply@openai.com>
skazistp-cpu
force-pushed
the
606_transparent_rpc_errors
branch
from
October 4, 2026 11:14
65a405f to
05f79f1
Compare
skazistp-cpu
marked this pull request as draft
October 4, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606. Preserve backend failures instead of reporting successful zero balances/empty UTXOs or a missing transaction. Unclassified transparent RPC errors return
Unknown;GetTransactionpreserves cancellation/deadline status and reservesNotFoundfor the structured missing-transaction error, including darksidewalletd.Regression coverage uses real in-memory gRPC, the HTTP JSON-RPC adapter, and the darkside backend. Jarvis used Codex for implementation and tests; Lagertha contributed the transaction-error lead. Exact-commit independent AI review and validation are recorded in the follow-up comment; no separate human review is implied.