fix(storage): add _is_open guard in ZipStore.exists to prevent AttributeError#3838
Open
NIK-TIGER-BILL wants to merge 1 commit intozarr-developers:mainfrom
Open
Conversation
…uteError ZipStore.exists() did not call self._sync_open() before accessing self._lock, causing AttributeError when called on an unopened store. Add the same _is_open check that other ZipStore methods (get, set, set_if_not_exists, delete) already use. Also add a regression test that instantiates ZipStore without an explicit .open() call and verifies exists() works correctly. Fixes zarr-developers#3588 Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ZipStore.exists()accessedself._lockdirectly without first checkingself._is_open, causing anAttributeErrorwhen the store was instantiated but not yet opened.All other mutating/reading methods in
ZipStore(e.g._get,_set,set,set_if_not_exists,delete) guard access toself._lockwith:exists()was the only method that missed this guard.Reproduction (before fix)
Fix
Added the missing
_is_opencheck at the top ofexists(), consistent with all other methods.Fixes #3588
TODO
docs/user-guide/*.mdchanges/