Skip to content

fix: values with zarf dev find-images#4734

Merged
brandtkeller merged 5 commits intomainfrom
fix-values-with-find-images
Apr 1, 2026
Merged

fix: values with zarf dev find-images#4734
brandtkeller merged 5 commits intomainfrom
fix-values-with-find-images

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

Description

find images is broken with values

Related Issue

Fixes #4629

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 20, 2026

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 39ebd39
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69cd25fc6c4bef00082e71fa
😎 Deploy Preview https://deploy-preview-4734--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AustinAbro321 AustinAbro321 marked this pull request as ready for review March 20, 2026 18:54
@AustinAbro321 AustinAbro321 requested review from a team as code owners March 20, 2026 18:54
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 49.12281% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/dev.go 44.44% 13 Missing and 2 partials ⚠️
src/pkg/packager/find_images.go 40.00% 4 Missing and 2 partials ⚠️
src/cmd/package.go 0.00% 3 Missing ⚠️
src/pkg/packager/packager.go 78.57% 2 Missing and 1 partial ⚠️
src/pkg/packager/inspect.go 33.33% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/inspect.go 34.90% <33.33%> (-2.07%) ⬇️
src/cmd/package.go 38.08% <0.00%> (+0.42%) ⬆️
src/pkg/packager/packager.go 83.33% <78.57%> (-0.82%) ⬇️
src/pkg/packager/find_images.go 55.85% <40.00%> (-0.76%) ⬇️
src/cmd/dev.go 45.65% <44.44%> (-0.56%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321 and others added 2 commits March 20, 2026 15:14
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear deviation on find images being resolved here. Cleaning up some of the shared logic into the helper looks good. Not sure if dev.go is the most intuitive location but otherwise not blocking. lgtm.

@brandtkeller brandtkeller added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 78b7202 Apr 1, 2026
43 checks passed
@brandtkeller brandtkeller deleted the fix-values-with-find-images branch April 1, 2026 16:17
@github-project-automation github-project-automation Bot moved this to Done in Zarf Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

zarf dev find-images fails when helm chart values with sourcepath are present

2 participants