Repository navigation
tui: /diagnostics when no language server is running - #110
Merged
Merged
Conversation
The one of the command's three outcomes that needs no gopls, so it runs everywhere: the throwaway HOME has no lsp.enabled, so the status line is deterministic, and the string is the literal from tui/update.go:1263. The listing outcome is deliberately not asserted. Its text cannot be read without gopls, and this machine has none — writing an assertion for a string nobody has seen is the mistake this suite keeps catching four times over. The scenario file says so, so the gap is recorded rather than implied. Measured: standalone ok, and the suite twice in a row. This is the last item of the scenario plan that can be verified here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one of
/diagnostics' three outcomes that needs no gopls, so it runs everywhere: the throwaway HOME has nolsp.enabled, the status line is deterministic, and the string is the literal fromtui/update.go:1263.The listing outcome is deliberately not asserted. Its text cannot be read without gopls, and this machine has none (
command -v gopls→ absent). Writing an assertion for a string nobody has seen is the mistake this suite has now caught four times, so the gap is recorded in the scenario file rather than implied — and it belongs to a gated line that runs where gopls exists, which is CI'slspjob.Verification: standalone
ok;make test-tui-scenariostwice in a row. This is the last item of the scenario plan that can be verified on this machine.