feat(libcgroups): Support sub-cgroups for unified systemd cgroup manager#3563
Open
logica0419 wants to merge 6 commits into
Open
feat(libcgroups): Support sub-cgroups for unified systemd cgroup manager#3563logica0419 wants to merge 6 commits into
logica0419 wants to merge 6 commits into
Conversation
Signed-off-by: Takuto Nagami <logica0419@gmail.com>
Signed-off-by: Takuto Nagami <logica0419@gmail.com>
Signed-off-by: Takuto Nagami <logica0419@gmail.com>
Signed-off-by: Takuto Nagami <logica0419@gmail.com>
Signed-off-by: Takuto Nagami <logica0419@gmail.com>
Signed-off-by: Takuto Nagami <logica0419@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for sub-cgroup paths within systemd-managed cgroups by extracting a sub-cgroup suffix from the unit name and propagating it through cgroup path construction and process addition.
Changes:
- New
extract_sub_cgrouphelper that splits anamelike{id}/sub/initinto base name and sub-cgroup suffix. construct_cgroups_pathandadd_taskupdated to incorporate the sub-cgroup path.- New unit tests for sub-cgroup extraction and path construction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 27, 2026
Contributor
Author
|
Although I worked on this as part of #3564, I’ve opened a separate issue for this PR since the enhancement is necessary regardless of the approach we take. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for sub-cgroups in the unified systemd cgroup manager.
Type of Change
Testing
Related Issues
fixes #3565
refs #3342
refs #3347
dependent #3564
Additional Context
#3347 (comment)