Conversation
- crm configure show strips ocf:heartbeat: from resource types - ignore quotes around values
Breaks ansible 2.0 compatibility
Remove commit stuff, as there is an implicit commit.
Update README according to usage of resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The highlight (apart from a couple of fixes regarding
crmoutput parsing) is Ansible 2.0 compatibility. Unfortunately in 2.0 modules can no longer use free-form parameters (only a few hardcoded whitelisted ones can) so this breaks playbook compatibility (must use resource: "whatever" as the parameter).Works for me in production with following resource types: