fix: reject template options where chunk_overlap >= chunk_size - #92
Merged
yifanfeng97 merged 1 commit intoSep 11, 2026
Merged
yifanfeng97 merged 1 commit into
yifanfeng97 merged 1 commit into
Conversation
…chunk_size Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Merged — verified locally that degenerate combos (overlap == size and overlap > size) are rejected with a clear author-facing message while valid pairs are unaffected. No bundled preset violates the constraint. One follow-up idea: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
YAML
options.chunk_sizeandoptions.chunk_overlaphave no cross-field check. When overlap is greater than or equal to size, character splitting degenerates (empty or non-progressing chunks).Fix
Validation runs on the unified
Optionsmodel used byparse_option:chunk_size, when set, must be>= 1chunk_overlap, when set, must be>= 0chunk_overlapmust be strictly smaller thanchunk_size(equality fails)Constructing an AutoType by hand is out of scope.
Tests
Parser tests cover valid pairs, overlap equal to size, overlap greater than size, non-positive size, negative overlap, and omitted fields. Bundled presets still load and
parse_optionstill succeeds. HE-T rules are unchanged.Compatibility
Templates that omit both fields behave as before. Rebased onto
v0.9.0/d8fce60. Does not touch ingest or provenance.Made with Cursor