You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
High Security: .github/workflows/aggregation_mode.yml stores PAPERSPACE_API_KEY as a GitHub Actions variable. This is a cloud API credential and should be a repository/environment secret: ${{ secrets.PAPERSPACE_API_KEY }}. Keep only PAPERSPACE_MACHINE_ID as a plain variable.
Medium Bug: infra/aggregation_mode/aggregation_mode.sh clones the repo into aligned_layer/, but the following commands still run from the parent directory. As a result, paths like aggregation_mode/proof_aggregator and ./infra/aggregation_mode/run.sh at lines 127 and 131 will not exist on a fresh setup. Fix by cloning into . or cd aligned_layer before building/copying.
Medium Bug: infra/aggregation_mode/run.sh does not stop on aggregation failures. If SP1 or Risc0 exits non-zero, the script still prints “finished” and reaches sudo shutdown -h now, likely making the daily run look successful while skipping aggregation. Add failure handling, for example set -euo pipefail plus a safe docker stop guard.
No significant performance issues found in this PR diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infra: run aggregation mode on a daily-scheduled GPU server
Description
Run the aggregation mode on a Paperspace GPU server that is only powered on once a day, instead of keeping it running 24/7.
Type of change
Checklist
testnet, everything else tostaging