fix(safe): also accept proposedByDelegate when filtering pending txs#236
Merged
Conversation
The proposer-based noise filter only checked tx["proposer"]. When a delegate proposes on behalf of a human signer, the human ends up in "proposer" and only "proposedByDelegate" is stable across humans, so every new signer alerted once even though the delegate was already trusted. Filter now matches on either field. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
spalen0
force-pushed
the
fix/safe-alert-noise-and-markdown
branch
from
259d907 to
8878ebf
Compare
spalen0
changed the title
Comment in addresses.py says values must be lowercase, but nothing enforces it. Normalize once when reading so a stray checksummed entry won't silently break the filter. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The proposer-based noise filter only checked
tx[\"proposer\"]. When a delegate proposes on behalf of a human signer, the human address ends up inproposerand onlyproposedByDelegateis stable across humans — so every new signer alerts once, even when the delegate is already on the trusted list. Concrete example: Strategist Multisig mainnet nonce 3250 alerted becauseproposer = 0xFafFb75e…(a human) while the bot wasproposedByDelegate = 0xcE434267….Filter now matches on either
proposerorproposedByDelegate. The Strategist delegate is already inYEARN_EXPECTED_PROPOSERSon main (added via the same refactor that swapped bots), so once this lands, nonce 3250 and similar pending txs get auto-skipped.Markdown-escape fixes from the original commit on this branch are now redundant with #234 and have been dropped on rebase.
Test plan
uv run ruff check ./uv run ruff format --check .).Monitor Safe Multisigsrun showsINFO safe: Skipping nonce 3250 on 0x16388463… — proposed by expected address 0xce434267…instead of firing an alert.🤖 Generated with Claude Code