Repository navigation
fix: add excerpts from theme/banner and theme/section inner blocks - #215
Open
YvetteNikolov wants to merge 1 commit into
Open
YvetteNikolov wants to merge 1 commit into
YvetteNikolov wants to merge 1 commit into
Conversation
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
ShunLuk,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1,
richardkorthuis and
rivanuff
and
a balanced review from Copilot
and removed request for
a team
November 16, 2026 13:24
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change that includes banner and section content in generated excerpts.
No open issues 🎉
What changed in this PR
Updates the Sage theme’s excerpt handling so content inside banner and section blocks can appear in generated excerpts, including card excerpts.
Changes:
- Adds
theme/bannerandtheme/sectionto the blocks whose inner content is included in excerpts. - Preserves existing support for
core/media-text.
| File | Description |
|---|---|
web/app/themes/sage/app/Hooks/Theme.php |
Extends the excerpt block list to include banners and sections. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodig zodat de introductie van je banner in de card excerpt komt