Skip to content

feat/animation review - #205

Merged
YvetteNikolov merged 4 commits into
mainfrom
feat/animation-review
Oct 27, 2026
Merged

YvetteNikolov merged 4 commits into
mainfrom
feat/animation-review

Conversation

@YvetteNikolov

Copy link
Copy Markdown
Contributor

N.a.v. https://github.com/emilkowalski/skills /review-animations en /find-animation-opportunities toegepast.

  • easings verbeterd, alles is nu snappier
  • Focus outline animation weggehaald (is blijkbaar toch heel irritant)
  • De mobile menu dropdown menu animatie toegevoegd

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to Blade and CSS animation refinements, with no unresolved blocking findings.

No open issues 🎉

What changed in this PR

This PR refines animations in the Sage theme, making header, navigation, and dialog transitions faster while removing animated keyboard-focus outlines.

Changes:

  • Adds shared easing curves and narrows transitions to specific properties.
  • Adds an entrance animation for mobile submenus.
  • Replaces the focus-outline animation with a static outline.
File Description
web/​app/​themes/​sage/​resources/​views/​sections/​header.blade.php Shortens the header transition and applies ease-out timing.
web/​app/​themes/​sage/​resources/​views/​components/​header/​search-bar.blade.php Refines search dialog and backdrop transitions.
web/​app/​themes/​sage/​resources/​views/​components/​header/​navigation.blade.php Animates navigation underlines horizontally.
web/​app/​themes/​sage/​resources/​views/​components/​header/​mobile-menu.blade.php Refines drawer transitions and adds submenu entrance motion.
web/​app/​themes/​sage/​resources/​views/​components/​header/​mega-dropdown.blade.php Shortens and scopes mega-menu transitions.
web/​app/​themes/​sage/​resources/​views/​components/​header/​dropdown.blade.php Sets explicit dropdown transition properties and timing.
web/​app/​themes/​sage/​resources/​views/​components/​facetwp/​mobile-filters.blade.php Applies shared drawer timing to mobile filters.
web/​app/​themes/​sage/​resources/​styles/​base/​theme.css Defines shared ease-out and drawer easing curves.
web/​app/​themes/​sage/​resources/​styles/​base/​base.css Removes focus keyframes while retaining a static keyboard-focus outline.

Review effort: Balanced

@YvetteNikolov

Copy link
Copy Markdown
Contributor Author

Met verbale approve van Wybe

@YvetteNikolov
YvetteNikolov merged commit eda6781 into main Oct 27, 2026
3 of 4 checks passed
@YvetteNikolov
YvetteNikolov deleted the feat/animation-review branch October 27, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants