Repository navigation
feat/animation review - #205
Merged
Merged
Conversation
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
ShunLuk,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1,
richardkorthuis and
rivanuff
and
a balanced review from Copilot
October 26, 2026 08:05
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to Blade and CSS animation refinements, with no unresolved blocking findings.
No open issues 🎉
What changed in this PR
This PR refines animations in the Sage theme, making header, navigation, and dialog transitions faster while removing animated keyboard-focus outlines.
Changes:
- Adds shared easing curves and narrows transitions to specific properties.
- Adds an entrance animation for mobile submenus.
- Replaces the focus-outline animation with a static outline.
| File | Description |
|---|---|
web/app/themes/sage/resources/views/sections/header.blade.php |
Shortens the header transition and applies ease-out timing. |
web/app/themes/sage/resources/views/components/header/search-bar.blade.php |
Refines search dialog and backdrop transitions. |
web/app/themes/sage/resources/views/components/header/navigation.blade.php |
Animates navigation underlines horizontally. |
web/app/themes/sage/resources/views/components/header/mobile-menu.blade.php |
Refines drawer transitions and adds submenu entrance motion. |
web/app/themes/sage/resources/views/components/header/mega-dropdown.blade.php |
Shortens and scopes mega-menu transitions. |
web/app/themes/sage/resources/views/components/header/dropdown.blade.php |
Sets explicit dropdown transition properties and timing. |
web/app/themes/sage/resources/views/components/facetwp/mobile-filters.blade.php |
Applies shared drawer timing to mobile filters. |
web/app/themes/sage/resources/styles/base/theme.css |
Defines shared ease-out and drawer easing curves. |
web/app/themes/sage/resources/styles/base/base.css |
Removes focus keyframes while retaining a static keyboard-focus outline. |
Review effort: Balanced
Contributor
Author
|
Met verbale approve van Wybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.a.v. https://github.com/emilkowalski/skills
/review-animationsen/find-animation-opportunitiestoegepast.