[Mlir] Skip default schedule for linalg.fill - #63
Open
ElectrikSpace wants to merge 1 commit into
Open
Conversation
ElectrikSpace
force-pushed
the
dev/snoiry/mlir_skip_fill
branch
from
March 11, 2026 15:11
54d6356 to
e404b60
Compare
Contributor
Author
|
rebase done |
Contributor
|
just wanted to note that this is compatible with fusion since fusion ignores fused producer handles including fills. |
ElectrikSpace
force-pushed
the
dev/snoiry/mlir_skip_fill
branch
from
April 30, 2026 13:00
3c39731 to
a63ca4b
Compare
qaco
approved these changes
May 1, 2026
qaco
left a comment
qaco
left a comment
Contributor
There was a problem hiding this comment.
Ok but at some point in the future I think we should be able to schedule the fill
Contributor
I think the main reason that we're not scheduling the fill is so that we can fuse them into the main op |
ElectrikSpace
force-pushed
the
dev/snoiry/mlir_skip_fill
branch
from
August 12, 2026 09:04
a63ca4b to
5546481
Compare
Contributor
Author
|
Exactly, I have a pass in SDist that fuse the fill op with the next op. (mandatory to have descent perf in my case).
|
Do not schedule the initialization operation linalg.fill, which is not controllable by the user. The default schedule applied can overconstraint lowering passes trying to fuse/optimize it.
ElectrikSpace
force-pushed
the
dev/snoiry/mlir_skip_fill
branch
from
August 12, 2026 09:36
5546481 to
6b4261c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not schedule the initialization operation linalg.fill, which is not controllable by the user.
Motivation
The default schedule applied can overconstraint lowering passes trying to fuse/optimize it.
Description
Based on the naming convention of Mlir nodes, skip the scheduling of the node corresponding to the linalg.fill.
Commits
Single commit
Discussion
What do you think ?