Skip to content

Fix MLIR transform dialect generation for nested splits - #114

Merged
guillon merged 1 commit into
xtc-tools:mainfrom
guillon:dev/cguillon/fix-nested-mlir-split
Aug 24, 2026
Merged

Fix MLIR transform dialect generation for nested splits#114
guillon merged 1 commit into
xtc-tools:mainfrom
guillon:dev/cguillon/fix-nested-mlir-split

Conversation

@guillon

@guillon guillon commented Aug 11, 2026

Copy link
Copy Markdown
Member

Motivation

Depends upon PR #113, refer to last commit only.

Fix code generation in MLIR backend for nested splits.

Description

When creating the SplitState, filter to the given loop root in order for the recursive split logic to work.

Commits

Ref to last commit

@guillon guillon changed the title Fix transform dislect generation for nested splits Fix MLIR transform dialect generation for nested splits Aug 11, 2026
@guillon
guillon requested a review from qaco August 11, 2026 19:16
@guillon
guillon force-pushed the dev/cguillon/fix-nested-mlir-split branch from f75ecf1 to 8ed6c9b Compare August 11, 2026 19:17
@guillon guillon added the bug Something isn't working label Aug 11, 2026
@guillon
guillon force-pushed the dev/cguillon/fix-nested-mlir-split branch 3 times, most recently from 4b2ae63 to 634736f Compare August 24, 2026 10:27
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@qaco qaco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense ^^

@guillon
guillon force-pushed the dev/cguillon/fix-nested-mlir-split branch from 634736f to 19e97f2 Compare August 24, 2026 12:55
@guillon
guillon force-pushed the dev/cguillon/fix-nested-mlir-split branch from 19e97f2 to e018f2f Compare August 24, 2026 13:30
@guillon
guillon merged commit 39b8cd4 into xtc-tools:main Aug 24, 2026
4 checks passed
@guillon
guillon deleted the dev/cguillon/fix-nested-mlir-split branch August 24, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants