Open help in the default browser, on the engine's new unified guide

.github/actions/smoke-test/action.yml

@@ -140,6 +140,11 @@ runs:
         if ("$so" -notmatch 'MBCS->UTF-8 ok') {
           throw "selftest did not exercise the MBCS->UTF-8 conversion"
         }
+        # Every help button hands one of these to the browser: an unescaped space truncates
+        # the path, an unescaped '#' names a file, since NTFS allows one in a filename.
+        if ("$so" -notmatch 'help URLs ok') {
+          throw "selftest did not check the help URLs"
+        }
         # Guards the empty-name terminator (newlang.h); losing it hangs the first-run About
         # box. [1-9] not \d: "after 0 entries" would pass while proving nothing.
         if ("$so" -notmatch 'language list ends after [1-9]\d* entries') {

.github/workflows/windows-build.yml

@@ -199,6 +199,28 @@ jobs:
           path: httrack
           submodules: recursive
 
+      - name: Help anchors resolve in the engine's guide
+        shell: pwsh
+        # The GUI deep-links into the engine's guide.html and the engine is unpinned, so a
+        # rename upstream lands here silently: the page still opens, it just never scrolls.
+        run: |
+          $guide = 'httrack\html\guide.html'
+          if (-not (Test-Path $guide)) {
+            throw "$guide is missing, so every help button would open nothing. The engine " +
+                  "predates the guide: move the HTTRACK_ENGINE_REF variable past xroche/httrack a21f84ee."
+          }
+          $page = Get-Content $guide -Raw
+          $anchors = Select-String -Path 'httrack-windows\WinHTTrack\*.cpp' `
+                       -Pattern 'HelpTopic\("([^"]+)"\)' -AllMatches |
+                     ForEach-Object { $_.Matches } |
+                     ForEach-Object { $_.Groups[1].Value } | Sort-Object -Unique
+          # Guard the scan itself: a regex that matched nothing would pass the loop below.
+          if ($anchors.Count -lt 10) { throw "found only $($anchors.Count) anchors; the scan is broken" }
+          foreach ($a in $anchors) {
+            if (-not $page.Contains("id=""$a""")) { throw "guide.html has no id='$a'" }
+          }
+          Write-Host "$($anchors.Count) help anchors resolve in guide.html"
+
       - name: Record engine provenance
         id: provenance
         shell: pwsh
@@ -503,7 +525,7 @@ jobs:
 
           # Supplied by Windows itself. The CRT names are gone from this list on purpose:
           # they are ours to ship now, so the check below catches a staging regression.
-          $provided = '^(api-ms-win-(?!crt-)|kernel32|user32|advapi32|shell32|comctl32|ole32|oleaut32|ws2_32|winmm|gdi32)'
+          $provided = '^(api-ms-win-(?!crt-)|kernel32|user32|advapi32|shell32|comctl32|ole32|oleaut32|ws2_32|winmm|gdi32|shlwapi)'
           $needed = @(Deps "$bin\WinHTTrack.exe") + @(Deps "$bin\httrack.exe") + @(Deps "$bin\libhttrack.dll") |
             Where-Object { $_ -notmatch $provided } | Sort-Object -Unique
           Write-Host "--- must ship: $($needed -join ', ') ---"