Conversation
Remove the xns->next = NULL hack from rxml_xpath_object_wrap. In XPath results, libxml2 stores the parent element pointer in xns->next (see xmlXPathNodeSetAddNs). Zeroing it broke xmlC14NIsNodeInNodeset which relies on that pointer to match namespace nodes in the input node set. Instead, guard Namespace#next to detect the XPath convention by checking whether next points to a namespace (type == XML_LOCAL_NAMESPACE). When canonicalize receives an XPath::Object for :nodes, pass the raw xmlNodeSet directly to xmlC14NDocDumpMemory instead of roundtripping through Ruby objects, which dropped namespace nodes. Enable W3C C14N spec examples 3.5 (entity references) and 3.7 (document subsets) which were previously commented out or marked TODO.
The negative-value loop was missing the assignment, so it asserted against the stale value (9) left by the previous loop. Also remove a Ruby 1.8 workaround comment.
The DTD initializer required external and system to be strings, making it impossible to create an internal DTD without public/system identifiers. Now nil is accepted for both parameters. Fixes #215
This reverts commit 53404f7.
Remove lib/xml.rb and lib/xml/libxml.rb which were deprecated entry points that polluted the global namespace. Use require 'libxml-ruby' instead. Revert require_relative back to require for loading the C extension so RubyGems can find the .so via $LOAD_PATH when installed as a gem. Update docs and changelog. Fixes #226
- Update benchmark scripts to require 'libxml-ruby' - Remove defined?(::Encoding) guard (always true on Ruby 3.2+) - Remove stale rdoc excludes for deleted files in Rakefile and docs CI - Remove ruby_xml_cbg.c references from Xcode project - Ship Xcode project in gem alongside VC project
The VC project glob had the wrong extension (.vcprojx vs .vcxproj) and wrong directory depth, so the .vcxproj was never packaged. Also exclude the generated extconf.h so local build config doesn't leak into the gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.