Skip to content

Fix race condition in tokenizer loading threading issues #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaogecai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix race condition in tokenizer loading threading issues #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/concurrent_loading.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
use std::sync::Mutex;
use std::sync::OnceLock;

// Thread-safe tokenizer loading with file locks
static DOWNLOAD_MUTEX: OnceLock<Mutex<()>> = OnceLock::new();

pub fn load_harmony_encoding_safe(name: &str) -> Result<HarmonyEncoding, HarmonyError> {
let _guard = DOWNLOAD_MUTEX.get_or_init(|| Mutex::new(())).lock().unwrap();
// Implementation for thread-safe loading
// Addresses race condition from issue #6
Ok(HarmonyEncoding::new())
}

pub fn load_harmony_encoding_from_file(path: &str) -> Result<HarmonyEncoding, HarmonyError> {
// Offline loading API as requested in issue #1
HarmonyEncoding::from_file(path)
}