Repository navigation
Similar scales cleanup - #986
Merged
frostburn merged 2 commits intoJul 19, 2026
Merged
Conversation
Closed
frostburn
reviewed
Jul 18, 2026
| }, | ||
| "dependencies": { | ||
| "@narenratan/scale-library": "1.3.0", | ||
| "@narenratan/scale-library": "1.3.1", |
Member
There was a problem hiding this comment.
The PRs are looking good. My only nitpick is this patch version bump. Adding library functions is at least worth a minor bump. I do appreciate that you're only publishing a small part of a larger system so we can let it slide.
Contributor
Author
There was a problem hiding this comment.
Thanks for having a look! Agreed it should really be a minor version bump; I thought I'd try and keep the main scale-library release, the npm package, and the Python package versions consistent (the main scale-library release is at 1.3.0 at the moment).
I've merged the scale-library PR and the new scale-library npm package version is published too.
Member
There was a problem hiding this comment.
Thanks, I'll merge tomorrow morning.
frostburn
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scale-librarynpm package and import it from thereResolves #985.
I created a corresponding scale-library PR in case it's of interest; it moves the similar scales code and sets up the packaging and testing config.