Add target CREATEDB preflight check for snapshot DB creation#996
Open
lghuy05 wants to merge 6 commits into
Open
Add target CREATEDB preflight check for snapshot DB creation#996lghuy05 wants to merge 6 commits into
lghuy05 wants to merge 6 commits into
Conversation
Contributor
Author
|
I will resolve the conflict in a few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new access preflight check for
pgstream checkto verify that the target Postgres role has theCREATEDBprivilege when snapshot schema restore is configured withcreated_target_db: true.Related Issue(s)
pgstream checkcommand for pre-migration sanity checks #897Type of Change
Please select the relevant option(s):
Changes Made
TargetCreateDBPrivilegeCheckto the access preflight checkscreate_target_db: trueTesting
Checklist
Additional Notes
This change only applies to the snapshot schema restore path for Postgres targets. The new check validates the current target session role by querying
pg_rolesforrolcreatedb, and returns an actionable finding when the privilege is missing.