Repository navigation
Rework FormExtraData - #278
Merged
Merged
Conversation
Adds versioning, better forward support. Adds removal events
Switched to templated maps Functions (except legacy) use __fastcall calling convention Made extradata destructors protected, to prevent accidental deallocation with non-game allocators
Game considers them already deleted at this point, so to better match game's tracking behavior, we should too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sigh, a deliberate ABI change due to design flaws of the previous one.
Changes:
The new ExtraData implementation is handled by new, tweaked variants of previous functions.
Backwards compatibility with previous ExtraData is maintained by using a separate map and functions. The separation is deliberate, in order to not leave NVSE plugins guessing if the ExtraData they found is using the old or new standard. The old class declaration has been moved into the LegacyFormExtraData.h file.
Changes to the class and enum names make an accidental upgrade not possible, requiring an explicit intervention when updating NVSE headers.