ci: add PR-time typecheck+test+build gate - #28
Open
asachs01 wants to merge 1 commit into
Open
Conversation
release.yml only triggers on push to main/develop/alpha - PRs get zero CI today, so a PR could merge with a broken build/test and nobody would know until the push-triggered release run fails after merge. Same gap class already closed on blackpoint-mcp#46 and datto-rmm-mcp. Mirrors that pattern: single Node 20 job (release.yml's push-triggered matrix already covers 20.x/22.x on main, so this stays a fast PR-time gate, not a duplicate matrix). No private-registry auth needed - this repo has zero @wyre-technology dependencies. Verified locally on current main: lint (tsc --noEmit) + test (15/15) + build all clean.
Member
Author
|
Analyst review — cleared, ready for Aaron's batch. Matches the established blackpoint-mcp#46 CI-gate pattern exactly (single Node 20 job: install/lint/test/build on PR+push to main, no docker job needed for a chore/CI-only change). Verified both pinned action SHAs (actions/checkout, actions/setup-node) genuinely resolve to their claimed tags via the GitHub API — not typosquatted or stale. Build job itself is green. Low-risk CI/tooling class per the autonomy rules. (Left as a comment, not an approve — gh blocks approving under the shared account identity, same mechanics issue as earlier today, not a real conflict.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlonly triggers on push tomain/develop/alpha, so PRs currently get zero CI signal before merge.tsc --noEmit, vitest, tsup build).task_1784769813181_35351102.@wyre-technology/node-huntressSDK client library, distinct fromhuntress-mcp(the MCP server) - different repo, different gap.What changed
.github/workflows/ci.yml: single Node 20 job running install → lint → test → build on every PR tomain. No docker/publish job - that staysrelease.yml's concern, this is PR-time gating only.release.yml's push-triggered job onmainalready covers the version matrix - this keeps PR CI fast without duplicating it.NODE_AUTH_TOKEN/registry-url) included - this repo has zero@wyre-technologydependencies, so it isn't needed (verified.npmrcuntouched).Test plan
npm cicleannpm run lint(tsc --noEmit) - cleannpm test- 15/15 passingnpm run build- clean🤖 Generated with Claude Code