Skip to content

ci(release): poll live Pages until a 10-minute deadline - #256

Merged
kanushka merged 1 commit into
wso2:mainfrom
kanushka:ci/pages-verify-deadline
Oct 14, 2026
Merged

kanushka merged 1 commit into
wso2:mainfrom
kanushka:ci/pages-verify-deadline

Conversation

@kanushka

Copy link
Copy Markdown
Contributor

Follow-up to #214

@kanushka
kanushka requested a review from hevayo as a code owner October 13, 2026 17:15
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bd74bfa2-3dc7-4a5d-9a8b-cf53f9b8a1f0
📥 Commits

Reviewing files that changed from the base of the PR and between 3899714 and 72ecb8a.

📒 Files selected for processing (1)
  • .github/workflows/module-release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

The live catalog check now polls every 15 seconds until an 11-minute deadline, with a 15-minute step timeout. It verifies that the module and index serve the released version and no longer adds cache-busting query parameters.

If verification fails, the workflow reports the attempt count and explains that rerunning the same-SHA deployment will not recover a deduplicated Pages deployment.

The live catalog verification step now polls the module and index checks until a 660-second deadline, with up to 15 seconds between attempts. The step has a 15-minute timeout and no longer adds timestamp query parameters to requests. If verification does not pass before the deadline, the workflow reports the attempt count and deadline, and notes that rerunning the same-SHA deployment will not recover a deduplicated Pages deployment.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 72ecb

The longer live-catalog polling window has no established merge-blocking issue. Merge after normal workflow checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 72ecb

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/module-release.yml: The live-verification step now has a 15-minute timeout and sets a 660-second polling deadline with a 15-second interval; the previous step had no explicit timeout or polling settings.
  • observed — Modified behavior in .github/workflows/module-release.yml: The fixed 18-attempt loop is replaced by deadline-based polling with an incrementing attempt counter. Requests no longer append timestamp query parameters, and the status message reports the deadline.
  • observed — Modified behavior in .github/workflows/module-release.yml: Polling stops when the deadline expires and sleeps for the lesser of the remaining time and configured interval. On failure, the workflow reports the deadline and attempt count and adds errors identifying same-SHA deduplication and stating that rerunning the failed jobs will not recover it.
Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains the polling deadline, timeout, cache-busting removal, failure-message update, and validation performed. It directly relates to the changeset.
Title check Passed The title clearly and concisely identifies the main change: polling live Pages until a 10-minute deadline during release CI.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kanushka
kanushka requested a review from axewilledge October 14, 2026 06:30
@kanushka
kanushka merged commit 7e5ff37 into wso2:main Oct 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants