feat: add AbortSignal support to announcement streams - #224
Open
official-rex wants to merge 1 commit into
Open
official-rex wants to merge 1 commit into
official-rex wants to merge 1 commit into
Conversation
|
@official-rex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
This PR only adds a test file. The announcement stream implementation is unchanged, so pending RPC requests and pagination are not cancelled. Please add the signal plumbing, put tests under the existing test tree, and fix formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds AbortSignal support to announcement streams so callers can cancel long-running or infinite stream subscriptions cleanly. When the signal fires, the stream throws a standard
AbortErrorand releases resources.Related Issue
Closes #200
Changes
[MODIFY]
packages/sdk-svelte/src/primitives/useStellarAnnouncementScan.tsoptions.signal?: AbortSignalparameter to stream functions.signal.abortedand throwAbortErrorwhen cancelled.[ADD]
tests/abort-signal.test.tsVerification Results