test: add package entrypoint smoke tests for every export - #217
Merged
truthixify merged 3 commits intoSep 25, 2026
Merged
truthixify merged 3 commits into
truthixify merged 3 commits into
Conversation
|
@collinsezedike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged. The entrypoint checks cover ESM, CJS, declarations, and browser-safe imports cleanly. Thanks @collinsezedike. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds smoke tests that import every published package entry point the way a consumer does, so a broken
exportsmap, a missing build artifact, an accidental Node-only import, or an unresolvable declaration file fails CI before release.Checks
Fixtures live in
test/smoke/and run viapnpm test:exportsafterpnpm build:exportssubpath through itsimportcondition and assert it exposes exports.exportssubpath through itsrequirecondition and assert it exposes exports.node:*or bare Node builtin, keeping the browser-safe entry points browser-safe.typestarget exists and type-checks when imported by its package specifier withtsc --noEmit.The entry point list is derived from
package.jsonexports, so new subpaths are covered automatically once they ship in the build.CI
A dedicated
entrypointsjob builds the package and runs the suite across Node 20 and 22.Notes
The Node-free check scans authored source rather than bundled output. A third-party dependency can select a Node crypto shim through export conditions, which would flag the bundle even though the package's own code is browser-safe. Scanning source targets the intended guard: code authored in this package never importing a Node-only module.
The CI workflow is covered by CODEOWNERS, so the workflow change requires maintainer review.
Closes #205