Comments v2: add the comment detail screen - #25949
Merged
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34055 | |
| Version | PR #25949 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | bd23c1d | |
| Installation URL | 2133c5m0f43og |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34055 | |
| Version | PR #25949 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | bd23c1d | |
| Installation URL | 1cjhcfrubn7jo |
jkmassel
approved these changes
Aug 27, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
Looks good – just one note – if there's not very much content, I'm surprised it scrolls at all. It probably shouldn't?
|
 |
| Scrolled to top | Scrolled to bottom |
The renderer was built for Reader cells that size themselves to the content. Add an `isScrollEnabled` option for hosts that pin the web view to a fixed region and let it scroll internally, with the native bounce (on overflow) and scroll indicator. It defaults to the previous behavior.
The detail screen shows unknown statuses verbatim, so `other` now carries the server's raw string.
Move the avatar double-optional flattening and the plain-text snippet rule out of the wire-type initializer so the detail model can reuse them, and treat a whitespace-only author name as anonymous.
`CommentDetail` maps either the view- or edit-context wire type. The service fetches with edit context when the user can moderate comments and falls back to view context on a 401/403, so a stale capability degrades to a read-only detail instead of an error.
Resolves the moderation capability once, fetches the detail, keeps the list row's seed painted while the request is in flight, loads the parent comment for the "In reply to" strip, and tracks the first successful view.
A fixed-region layout: pinned status pill and author header, an optional parent strip, and an injected content renderer that scrolls internally. The router owns the shared dependencies and pushes detail screens onto the list controller's navigation stack, so a parent comment can push recursively.
List rows become buttons that push the detail screen. The app supplies the web content renderer and the analytics adapter to the hosting controller.
Contributor
Author
crazytonyli
force-pushed
the
task/comments-v2-m2-detail
branch
from
August 30, 2026 21:17
83b0fc1 to
bd23c1d
Compare
crazytonyli
enabled auto-merge
August 30, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
details.mp4