Use size_t in wolfSSL_strnstr and reject negative indices in mp_get_digit#10138
Draft
padelsbach wants to merge 1 commit intowolfSSL:masterfrom
Draft
Use size_t in wolfSSL_strnstr and reject negative indices in mp_get_digit#10138padelsbach wants to merge 1 commit intowolfSSL:masterfrom
padelsbach wants to merge 1 commit intowolfSSL:masterfrom
Conversation
padelsbach
commented
Apr 6, 2026
| mp_digit mp_get_digit(const mp_int* a, int n) | ||
| { | ||
| if (a == NULL) | ||
| if (a == NULL || n < 0) |
Contributor
Author
There was a problem hiding this comment.
No logic change, just makes the code more analyzer friendly per the ZD ticket.
Contributor
Author
|
jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe the scope of the fix or feature addition.
Fixes zd21539
Testing
Manual review
Checklist