Remove alertdialog and application from non-interactive ARIA roles in…#16074
Closed
Vegapunk-debug wants to merge 4 commits intowithastro:mainfrom
Closed
Remove alertdialog and application from non-interactive ARIA roles in…#16074Vegapunk-debug wants to merge 4 commits intowithastro:mainfrom
Vegapunk-debug wants to merge 4 commits intowithastro:mainfrom
Conversation
… dev toolbar audit
🦋 Changeset detectedLatest commit: ac1ee72 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
alertdialogandapplicationfrom thearia_non_interactive_rolesarray in the dev toolbar. Per WAI-ARIA, these are interactive widget roles, not document structure roles.a11y-missing-attributeerror message.Testing
This is a static data array update, so no new tests were added. The existing
a11y-no-interactive-element-to-noninteractive-roleanda11y-no-noninteractive-element-to-interactive-rolerules automatically pick up the corrected classifications. Verified locally that the test suite passes.Docs
No documentation updates needed. This strictly fixes internal dev toolbar audit behavior to align with the WAI-ARIA spec and does not affect public APIs.
THANK YOU