Skip to content

Add INCLUDE_LOG to remove logs from build #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephaneTriomphe merged 1 commit into from
Jun 4, 2026
Merged

Add INCLUDE_LOG to remove logs from build #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/api/logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,15 @@ extern int *Platform_get_logging_module_level(const char *const module_name, con
# define MAX_LOG_LEVEL ERROR_LOG_LEVEL
#endif

#if !defined(INCLUDE_LOG)

@GwendalRaoul GwendalRaoul Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the flag?
Just a shortcut instead of defininig MAX_LOG_LEVEL to NO_LOG_LEVEL directly ?
CFLAGS += -DMAX_LOG_LEVEL =-1 wouldn't work directly?

@StephaneTriomphe StephaneTriomphe Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAX_LOG_LEVEL is set by each file before including logger.h.
If I understand your proposal, MAX_LOG_LEVEL defined with cflags will be redefined, so it will not work, no ?

@GwendalRaoul GwendalRaoul Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I missed this point!

# define INCLUDE_LOG 1
#endif

#if (!INCLUDE_LOG)
#undef MAX_LOG_LEVEL
#define MAX_LOG_LEVEL NO_LOG_LEVEL
#endif

#ifndef LOG_MODULE_NAME
/* Name of the module */
# error "No module name set for logger"
Expand Down
Loading