Enforce conventional commits with a commit-msg hook - #296
Open
jenul-ferdinand wants to merge 3 commits into
Open
Enforce conventional commits with a commit-msg hook#296jenul-ferdinand wants to merge 3 commits into
jenul-ferdinand wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
commit-msghook lived only ondevelop, which sat 177 commits behind main and never merged. This branch carries the hook over so we can dropdevelop.What this adds
.githooks/commit-msg: a POSIX sh hook that rejects subjects which aren't Conventional Commits.make hookstarget (also run bymake install) that enables it viacore.hooksPath.Each clone opts in. Nothing changes for anyone who skips
make hooks.Verification
I ran the hook against 16 messages, 10 valid and 6 invalid. All 16 classified correctly, including uppercase scopes (
fix(Vercel):), breaking-change markers (feat!:), and theamend!/fixup!/merge/revert pass-throughs. It checks the subject line only, not the body or footer.developis already deleted; this branch holds the only copy of the hook until it merges.