Repository navigation
fix(http): restore query responses and normalize options - #2656
Open
minjungsung wants to merge 1 commit into
Open
minjungsung wants to merge 1 commit into
minjungsung wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP transport queries currently throw
TypeError: this.normalizeQuery is not a function. They also discard the HTTP response body, preventing query results from reaching the callback. The documented log-query API therefore does not work in Winston 3.19.0.Normalize query options locally without mutating the caller's object, retain the existing File transport's defaults, and collect query response chunks before decoding UTF-8 and parsing JSON. Send queries directly even when log batching is enabled. A private Symbol distinguishes query requests without colliding with log metadata; regular logging responses still drain without buffering.
Add four local HTTP-server regressions covering results with batching enabled/disabled, a split multibyte response, unchanged caller options, and malformed/empty responses.
Validation:
Related history: #787 fixed response collection in the former implementation; this restores the behavior in the current 3.x transport.
AI assistance: implementation, tests, and this description were prepared with Codex.