Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
profiler.done()drops the logger'sdefaultMeta. Finishing a timer logs the message and duration, but not the metadata configured on the logger (#2162).Root cause
Profiler#donebuilds the info object and callslogger.write()directly.defaultMetais applied inLogger#log, not inwrite.Fix
Merge
defaultMetaunderneath that info object beforewrite. Fields passed todone(), includinglevelanddurationMs, still win.Tests
test/unit/winston/profiler.test.jschecks thatservicefromdefaultMetais present and that an explicitmessageoverrides a default message. That assertion fails on master and passes with this change. The existing profiler tests still pass.Scope
lib/winston/profiler.jsonly.Fixes #2162