Repository navigation
Preserve empty strings in HTTP Basic authentication credentials - #2647
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP transport omits Basic authentication whenever either credential is an empty string. This breaks endpoints that use a token as the username with an empty password, or the inverse, even though both are valid Basic credentials.
Check that both credentials are strings instead of requiring them to be truthy. Add real local HTTP-server tests that inspect the outgoing Authorization header for an empty username, an empty password, both empty, and ordinary credentials.
Three regressions fail before the fix. All 74 HTTP transport and logger tests pass afterward (one existing todo). The full lint command passes with ten existing warnings and no errors.