Skip to content

fix(http): accept successful 2xx responses #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootsec1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(http): accept successful 2xx responses #2641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/winston/transports/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module.exports = class Http extends TransportStream {
*/
log(info, callback) {
this._request(info, null, null, (err, res) => {
if (res && res.statusCode !== 200) {
if (res && (res.statusCode < 200 || res.statusCode >= 300)) {
err = new Error(`Invalid HTTP Status Code: ${res.statusCode}`);
}

Expand Down
53 changes: 51 additions & 2 deletions test/unit/winston/transports/http.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const stringifyJson = require('safe-stable-stringify');
const host = '127.0.0.1';
const port = 0;

function mockHttpServer(done, expectedLog) {
function mockHttpServer(done, expectedLog, statusCode = 200) {

const mock = hock.createHock();
const opts = {
Expand All @@ -25,7 +25,7 @@ function mockHttpServer(done, expectedLog) {
.post('/' + opts.path, opts.payload)
.min(1)
.max(1)
.reply(200);
.reply(statusCode);

var server = http.createServer(mock.handler);
server.listen(port, '0.0.0.0', done);
Expand Down Expand Up @@ -79,6 +79,55 @@ describe('Http({ host, port, path })', function () {

});

describe('successful HTTP status codes', function () {

beforeEach(function (done) {
context = mockHttpServer(done, dummyLog, 204);
server = context.server;
});

it('should accept non-200 2xx responses', function (done) {
const httpTransport = new Http({
host: host,
port: server.address().port,
path: 'log'
})
.on('warn', done)
.on('logged', function () {
onLogged(context, done);
});

httpTransport.log(dummyLog, assumeError);
});

});

describe('unsuccessful HTTP status codes', function () {

beforeEach(function (done) {
context = mockHttpServer(done, dummyLog, 300);
server = context.server;
});

it('should reject non-2xx responses', function (done) {
const httpTransport = new Http({
host: host,
port: server.address().port,
path: 'log'
})
.on('warn', function (err) {
assume(err.message).equals('Invalid HTTP Status Code: 300');
onLogged(context, done);
})
.on('logged', function () {
done(new Error('Unexpected logged event'));
});

httpTransport.log(dummyLog, assumeError);
});

});

describe('batch mode: max message', function () {

beforeEach(function (done) {
Expand Down