Remove the ChatGPT sign-in from the AI providers panel#85
Merged
Conversation
Follows the backend removal of the Codex/ChatGPT OAuth rank provider (it couldn't do embeddings, so it was dropped). Removes the client surface: - _ChatGptSignInCard (device-flow widget) and its use in the section - ChatgptLoginStatus / ChatgptPollResult models - getChatgptLogin / startChatgptLogin / pollChatgptLogin / clearChatgptLogin api_service methods + the chatgpt-login endpoint constants - the now-unused dart:async and browser_link imports - test references The AI providers panel is otherwise unchanged: per-provider keys (Anthropic/Gemini/OpenAI) and the embed/rank selection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the backend removal of the Codex/ChatGPT OAuth rank provider (windoze95/nullfeed-backend#131) — it only served ranking and couldn't do embeddings, so it's out. This removes the client surface:
_ChatGptSignInCard(the device-flow widget) and its placement in the sectionChatgptLoginStatus/ChatgptPollResultmodels*ChatgptLoginapi_service methods + thechatgpt-loginendpoint constantsdart:asyncandbrowser_linkimportsThe AI providers panel is otherwise unchanged: per-provider keys (Anthropic / Gemini / OpenAI) and the embedding/ranking provider selection.
dart formatclean,flutter analyze --fatal-infos --fatal-warningsclean, all 233 tests pass locally.🤖 Generated with Claude Code