fix: give the wordmark an opaque white background so it stays legible on dark pages - #195
Closed
willyfh wants to merge 2 commits into
Closed
fix: give the wordmark an opaque white background so it stays legible on dark pages#195willyfh wants to merge 2 commits into
willyfh wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #194 (merged before this second commit landed - timing race).
The wordmark still has a transparent background on main right now, with "Visual" in near-black - invisible on GitHub/RTD dark backgrounds, which was the whole reason a separate dark variant existed before #194 removed it.
Gives wordmark-light.png an opaque white background instead, so it's genuinely one consistent asset: blends in on light backgrounds, shows as a clean white card on dark ones, fully legible either way. No code changes needed - conf.py/README already point at this same file.
Verified by compositing on GitHub's actual dark background color (#0d1117) and confirming the docs build succeeds.