fix: use a square favicon instead of stretching the tall flame icon - #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browsers force favicons into a square display slot. `traced-flame-icon.png` (48x69, tall/narrow) was being squashed/stretched to fit, distorting the flame's proportions in the browser tab.
Adds `traced-flame-favicon.png` (64x64, transparent side padding, no distortion) and points `html_favicon` at it. `traced-flame-icon.png` is untouched and still used by `scripts/generate_star_history.py` for the chart watermark, where non-square is fine (no forced-square constraint there).
Test plan
pre-commit run --files <changed>cleansphinx-buildsucceeded; confirmed the new favicon file is correctly copied into the build output