Skip to content

fix: preserve Tempo fee-payer-signed fields - #5012

Merged
jxom merged 5 commits into
mainfrom
struong/fix-tempo-fee-payer-signed-fields
Aug 16, 2026
Merged

fix: preserve Tempo fee-payer-signed fields#5012
jxom merged 5 commits into
mainfrom
struong/fix-tempo-fee-payer-signed-fields

Conversation

@struong

@struong struong commented Aug 14, 2026

Copy link
Copy Markdown
Member

Summary

Preserves filled Tempo transaction fields after eth_fillTransaction returns a fee payer signature.

Motivation

Caller-provided gas, fee, or nonce preferences could overwrite fields selected and signed by a fee payer, producing a final transaction whose payload no longer matched the fee payer signature.

Changes

  • Skipped caller preference and fee multiplier processing once a non-null fee payer signature is present.
  • Preserved unsigned eth_fillTransaction behavior.
  • Added focused fill-boundary coverage and a Tempo transport regression for the final signed transaction path.
  • Added a patch changeset.

Testing

  • ./node_modules/.bin/biome check --write src/actions/public/fillTransaction.ts src/actions/public/fillTransaction.test.ts src/tempo/Transport.test.ts
  • ./node_modules/.bin/tsc -b
  • ./node_modules/.bin/vitest run --config test/vitest.config.ts src/actions/public/fillTransaction.test.ts -t "fee-payer-signed|unsigned relay"
  • Tempo transport regression was attempted locally, but shared node setup returned HTTP 400 for eth_getBlockByNumber before tests executed.

@changeset-bot

changeset-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc0dd62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
viem Ready Ready Preview Aug 16, 2026 10:54pm

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/viem@5012

commit: 8bdd349

@jxom
jxom disabled auto-merge August 16, 2026 22:50
@jxom
jxom merged commit 5e43605 into main Aug 16, 2026
5 of 6 checks passed
@jxom
jxom deleted the struong/fix-tempo-fee-payer-signed-fields branch August 16, 2026 22:50
@github-actions github-actions Bot mentioned this pull request Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants