Repository navigation
feat(types): add TypedHookMap type - #195
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 13 13
Lines 686 686
Branches 110 110
=======================================
Hits 672 672
Misses 13 13
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure how much this matters, but this did break the test on DT: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/tapable/tapable-tests.ts Since this is a breaking change, removing a parameter like this. Was the change intended? (I am not super familiar with this package.) |
|
I am not attached to this test, it seems pretty place-holder-y, so I'm going to change it, but I mention it just because someone else might break. |
|
@jakebailey yeah, it was a bug fix, look at code and you will see that we have wrong types |
Summary
Added
TypedHookMapwith typed for/keyWhat kind of change does this PR introduce?
types
Did you add tests for your changes?
No need
Does this PR introduce a breaking change?
No, because it is a new type
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing