Repository navigation
Streams: test respond() on a detached pull-into descriptor - #64195
Draft
MattiasBuelens wants to merge 1 commit into
Draft
MattiasBuelens wants to merge 1 commit into
MattiasBuelens wants to merge 1 commit into
Conversation
Responding to a pull-into descriptor whose reader type is "none" moves the bytes written into it to the queue, and then fills any pending pull-into descriptors from that queue. It never fills pending read requests, so with a default reader and no autoAllocateChunkSize the bytes stay queued and the read() never settles. See whatwg/streams#1390.
2 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a BYOB reader is released while its
read(view)request is partially filled, the request’s pull-into descriptor remains pending. When the underlying source later callsrespond(), the bytes written so far are moved into the stream’s queue. A pendingread()request from a default reader acquired afterwards should then be fulfilled with those queued bytes.Accompanies whatwg/streams#1393.
See whatwg/streams#1390.