Repository navigation
Pass auth to bugs.webkit.org properly - #274
Merged
gsnedders merged 1 commit intoOct 22, 2026
Merged
Conversation
gsnedders
force-pushed
the
fix-webkit-export-auth
branch
from
October 21, 2026 15:26
ae1d46f to
b4109fd
Compare
gsnedders
commented
Oct 21, 2026
| webhookSecret: await fetchSecret('github-webhook-secret'), | ||
| githubToken: await fetchSecret('wpt-pr-bot-github-token'), | ||
| bugsWebkit: await fetchSecret('wpt-pr-bot-bugswebkit-token'), | ||
| bugsWebkitToken: await fetchSecret('wpt-pr-bot-bugswebkit-token'), |
Member
Author
There was a problem hiding this comment.
Given this had been broken, @DanielRyanSmith, can you check this actually exists and works?
Collaborator
There was a problem hiding this comment.
I have confirmed the code here retrieves full emails back with this change
DanielRyanSmith
approved these changes
Oct 21, 2026
DanielRyanSmith
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking a look at this
bugs.webkit.org only reads credentials from request parameters, not headers, so the `X-BUGZILLA-TOKEN` header was ignored and every request was made logged out. Logged-out responses now truncate email addresses (`ews-feeder` rather than `ews-feeder@webkit.org`), so the bot no longer recognised changes made by EWS or the commit queue and stopped approving WebKit export PRs. Send the API key as the `Bugzilla_api_key` query parameter instead, and redact it when logging. Also ask for `exclude_fields=update_token`, since authenticated responses otherwise include a per-user token. `create-secrets.js` returned the secret as `bugsWebkit` while `index.js` reads `bugsWebkitToken`, so the token was never set in production. Tests replay requests with a placeholder key. The real key is replaced with `REDACTED` both when saving fixtures and when matching them, so recording with a real key replays existing fixtures instead of duplicating them. The fixtures are re-recorded while authenticated. The "wrong bugzilla reference" test passed without asserting anything: bug 202311 loads fine when authenticated, so the rejection handler never ran. Point it at a nonexistent bug so it covers the error path again.
gsnedders
force-pushed
the
fix-webkit-export-auth
branch
from
October 22, 2026 03:06
b4109fd to
8d5f383
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugs.webkit.org only reads credentials from request parameters, not headers, so the
X-BUGZILLA-TOKENheader was ignored and every request was made logged out. Logged-out responses now truncate email addresses (ews-feederrather thanews-feeder@webkit.org), so the bot no longer recognised changes made by EWS or the commit queue and stopped approving WebKit export PRs.Send the API key as the
Bugzilla_api_keyquery parameter instead, and redact it when logging. Also ask forexclude_fields=update_token, since authenticated responses otherwise include a per-user token.create-secrets.jsreturned the secret asbugsWebkitwhileindex.jsreadsbugsWebkitToken, so the token was never set in production.Tests replay requests with a placeholder key. The real key is replaced with
REDACTEDboth when saving fixtures and when matching them, so recording with a real key replays existing fixtures instead of duplicating them. The fixtures are re-recorded while authenticated.The "wrong bugzilla reference" test passed without asserting anything: bug 202311 loads fine when authenticated, so the rejection handler never ran. Point it at a nonexistent bug so it covers the error path again.
See also, an alternative fix: #273