Readme updates - #80
Merged
Merged
Conversation
Closed
mrts
requested changes
Aug 25, 2026
aarmam
added a commit
that referenced
this pull request
Aug 27, 2026
The field definitions of the authentication token belong to the canonical Web eID authentication token specification. Reproducing them here created a second normative-looking copy that was already incomplete, as it omitted the web-eid:1.1 intermediate certificate fields. Keep the illustrative token examples and link to the canonical definition instead. Addresses review comment #80 (comment) Signed-off-by: Mart Aarma <mart.aarma@nortal.com>
aarmam
added a commit
that referenced
this pull request
Aug 27, 2026
web-eid:1.0 is not desktop-only, the mobile flow also uses it when signing certificate information is not requested. Describe it as the base authentication token format without signing certificate information and web-eid:1.1 as its extension. Move the description next to the token format section, where it belongs, and drop the duplicated field list. Addresses review comment #80 (comment) Signed-off-by: Mart Aarma <mart.aarma@nortal.com>
aarmam
added a commit
that referenced
this pull request
Aug 27, 2026
…E example Addresses review comment #80 (comment) Signed-off-by: Mart Aarma <mart.aarma@nortal.com>
aarmam
added a commit
that referenced
this pull request
Aug 27, 2026
The field definitions of the authentication token belong to the canonical Web eID authentication token specification. Reproducing them here created a second normative-looking copy that was already incomplete, as it omitted the web-eid:1.1 intermediate certificate fields. Keep the illustrative token examples and link to the canonical definition instead. Addresses review comment #80 (comment) Signed-off-by: Mart Aarma <mart.aarma@nortal.com>
aarmam
added a commit
that referenced
this pull request
Aug 27, 2026
web-eid:1.0 is not desktop-only, the mobile flow also uses it when signing certificate information is not requested. Describe it as the base authentication token format without signing certificate information and web-eid:1.1 as its extension. Move the description next to the token format section, where it belongs, and drop the duplicated field list. Addresses review comment #80 (comment) Signed-off-by: Mart Aarma <mart.aarma@nortal.com>
NFC-149 Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com> Co-authored-by: Mart Aarma <mart.aarma@nortal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mart Aarma mart.aarma@nortal.com