Enable nld_classifier_v3 and nld_heuristic_v2 for all channels#12273
Conversation
Previously only local/dev used the v3 ONNX classifier + v2 shell heuristic, preview used v2 classifier + v2 heuristic, and stable used v1 classifier + v1 heuristic. This sets warpdev, warplocal, preview, and stable all to nld_classifier_v3 + nld_heuristic_v2 across the macOS, Linux, and Windows bundle scripts. The oss channel is left on v1/v1. CHANGELOG-NONE Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the Linux, macOS, and Windows bundle scripts so non-OSS app bundles use nld_classifier_v3 with nld_heuristic_v2, while OSS remains on the v1 classifier and heuristic.
Concerns
- This is a user-facing behavior change: preview and stable users can see different command-vs-natural-language classification behavior, but the PR description does not include screenshots or a screen recording demonstrating the new classifier/heuristic working end to end. Please attach visual evidence from a manual run showing representative inputs before merge.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Apply nld_classifier_v3 + nld_heuristic_v2 to every release channel (local, dev, preview, stable, oss) instead of leaving oss on v1/v1. CHANGELOG-NONE Co-Authored-By: Oz <oz-agent@warp.dev>
| # All channels ship the v3 classifier and v2 heuristic. | ||
| FEATURES="$FEATURES,nld_classifier_v3,nld_heuristic_v2" |
There was a problem hiding this comment.
nit: here and in the other ones, please combine with line 355
| $FEATURES = "$FEATURES,nld_classifier_v1,nld_heuristic_v1" | ||
| } | ||
| # All channels ship the v3 classifier and v2 heuristic. | ||
| $FEATURES = "$FEATURES,nld_classifier_v3,nld_heuristic_v2" |
evelyn-with-warp
deleted the
evelyn/nld-classifier-v3-heuristic-v2-all-channels
branch
2 participants
Description
Enables the v3 ONNX input classifier (
nld_classifier_v3) and the v2 shell-command heuristic (nld_heuristic_v2) across all release channels: warpdev (dev), warplocal (local),preview,stable, andossLinked Issue
Testing
Build-script-only change. Recommend validating with the bundle scripts' `--check-only` path per channel (e.g. `cargo check` with the resulting feature set) for preview and stable to confirm the v3 feature set compiles.
Agent Mode
Conversation: https://staging.warp.dev/conversation/130089d5-cc2a-4235-8af3-053718cd45c7
Co-Authored-By: Oz oz-agent@warp.dev