Repository navigation
docs: editorial review of product overviews, factories, and quickstarts - #910
rachaelrenk wants to merge 29 commits into
Conversation
Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR retitles the docs home page to "Warp products overview" and tightens the introductory paragraph to separate Warp Agent, cloud automation, and Warp Factories positioning.
Concerns
- No blocking concerns found. The prose-only changes align with the page's overview purpose, keep CLI details in the existing Warp Agent section, and do not introduce security-sensitive behavior.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Warp <agent@warp.dev>
Pricing review requested: HYCWe are simplifying the Warp Factories quickstart prerequisites into a direct, scannable list. The proposed usage bullet is:
@hongyi-chen: please advise on the customer-facing requirement and wording, including any plan eligibility, balance, purchase-setting, or Enterprise exceptions needed before someone can complete the quickstart. We want a concrete prerequisite without duplicating the billing reference or applying standalone integration rules to factories without verification. This wording is provisional pending your input. The edits are currently local and will be included in the next push. Any equivalent cloud-run prerequisites will need the same billing review. |
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Preserve the networking section and use the current team-settings lookup for hosted-agent egress ranges. Co-Authored-By: Warp <agent@warp.dev>
There was a problem hiding this comment.
Overview
This reorganizes factory agent docs and tightens product overviews and setup guidance. Please address the new permission prerequisite and decide how to handle the retained accuracy issues and documentation-contract exceptions below.
Concerns
- [Important] Record page-specific compression exceptions or remove redundancy. The required checker finds inherited word-budget overages in
agents/cli/quickstart.mdx(874),platform/integrations/quickstart.mdx(678),platform/triggers/scheduled-agents-quickstart.mdx(726), andquickstart.mdx(758), against the approximately 600-word quickstart budget;factories/self-hosting/managed-kubernetes.mdx(2,066),factories/webhooks.mdx(2,073), andplatform/integrations/github.mdx(2,526) exceed the 1,500-word combined-page budget. Three callouts remain inagents/cli/quickstart.mdx,platform/integrations/github.mdx, andplatform/harnesses/authentication.mdx; justify necessary exceptions in the PR body rather than mechanically splitting pages or cutting teaching, and distinguish these inherited overages from new regressions. - [Suggestion] Shorten the PR description. Replace the successive per-page and per-commit chronicles with the problem, net outcome, and current validation, retaining required risk metadata and limitations.
Validation: CI build/link audit passed; typecheck, heading tests, redirect tests, internal-link checks, and UI-reference checks passed during review. The ordinary local build hit a Node stack overflow; an increased-stack build and its generated-HTML checks passed. Preview navigation, compatibility anchors, and screenshot legibility were examined, but live factory setup, authentication, self-hosting, and billing were not exercised.
Automated reviews produced content findings before their publication step failed with Argument list too long; red review CI is not a docs-build failure.
Verdict
Checks: build pass in CI (local stack caveat above), tests pass, CI red, visual proof present.
Found: 0 critical, 2 important, 4 suggestions, 0 nits. One important finding is an introduced permissions error; the accuracy suggestions and compression overages are explicitly inherited.
Responding as Docs Factory (V2): Open session · View in factory
| * [Full Terminal Use](/agents/capabilities/full-terminal-use/) - Let agents drive interactive terminal apps, see live output, and run commands | ||
| * [Viewing cloud agent runs](/platform/viewing-cloud-agent-runs/) - Open the cloud run transcript and artifacts after a Computer Use session finishes | ||
| * [Factory agents](/factories/factory-agents/) - Roles and responsibilities for factory agents | ||
| * [About factory agents](/factories/factory-agents/) - Roles and responsibilities for factory agents |
There was a problem hiding this comment.
curious why we need "about" here?
There was a problem hiding this comment.
About matches the renamed destination title. Our conceptual-title guidance also permits a plain noun phrase, so it is optional. “Factory agents” is equally valid if the page title, sidebar, and title-based links change together.
Responding as Docs Factory (V2): Open session · View in factory
|
|
||
| * [{VARS.WARP_PLATFORM_API}](/factories/api-and-sdk/) — API reference for creating and managing agent tasks | ||
| * [Cloud Agents Overview](/platform/) — How cloud agents work | ||
| * [Cloud agents overview](/platform/) — How cloud agents work |
There was a problem hiding this comment.
feels weird to be making it lower case when "Access, Billing, Identity" below are capitalized - let's standardize on some approach here and make sure this is reflected all throughout
There was a problem hiding this comment.
Sentence case is the current rule, preserving proper names and exact UI labels. This pass missed “Access, Billing, and Identity”; the destination title is “Access, billing, and identity permissions.” The same stale label needs a sweep in sibling error pages and the Enterprise billing page.
Responding as Docs Factory (V2): Open session · View in factory
There was a problem hiding this comment.
Correct, this title was incorrectly capitalized, per the style guide we should use sentence-case for page titles
| * [Integrations](/platform/integrations/) — Integration setup guides | ||
| * [Slack Integration](/platform/integrations/slack/) — Slack-specific setup | ||
| * [Linear Integration](/platform/integrations/linear/) — Linear-specific setup | ||
| * [Slack integration](/platform/integrations/slack/) — Slack-specific setup |
There was a problem hiding this comment.
similar comment to above here
There was a problem hiding this comment.
Slack integration and Linear integration match their destination titles: Slack and Linear are proper names, while “integration” is lowercase. The broader consistency sweep should apply that rule rather than reverting these two labels.
Responding as Docs Factory (V2): Open session · View in factory
| label: 'Infrastructure', | ||
| items: [ | ||
| { slug: 'factories/infrastructure-and-security', label: 'Overview' }, | ||
| { slug: 'factories/infrastructure-and-security', label: 'About infrastructure and security' }, |
There was a problem hiding this comment.
Hmm curious why we're adding "About" to the beginning? is this the convention across other docs platforms
There was a problem hiding this comment.
About is not required by our guide or universal across docs platforms. GitHub uses About repositories, while other docs use noun phrases or task-based titles. “Infrastructure and security” is valid too; the prefix is an editorial choice, not a requirement.
Responding as Docs Factory (V2): Open session · View in factory
| ## Factory role and integration skills | ||
|
|
||
| Every default agent starts with a baseline of role and integration skills so the factory works immediately after setup, before you write anything custom: | ||
| <span id="factory-role-and-integration-skills" /> |
There was a problem hiding this comment.
hmm why did we remove all of this content here previously?
i think the custom file-based factory skills could be helpful
There was a problem hiding this comment.
Custom-skill setup remains under “Add or edit a skill,” including shared and agent-specific paths. The illustrative directory tree was removed, not the setup instructions. Restoring a compact tree beside those scope choices would preserve a useful reader aid without duplicating the full reference.
Responding as Docs Factory (V2): Open session · View in factory
There was a problem hiding this comment.
Restored a compact directory tree beside the shared-versus-agent-specific scope choices in Add or edit a skill. The setup instructions and both file paths remain inline, and the definition link now goes directly to the canonical directory-structure section. Included in 97a116ac.
| | `tui-migrate-setup` | Migrate supported settings into the Warp Agent CLI. | | ||
| | `update-tab-config` | Update an existing Warp tab configuration. | | ||
| | `warpctrl` | Control and inspect a running Warp app with Warp Control. | | ||
| <span id="attribute-team-owned-skill-usage" /> |
There was a problem hiding this comment.
same with this table, is it somewhere else now?
There was a problem hiding this comment.
Yes—the identical table already exists in Skill actions in conversation data, and this page links there. This PR removes the duplicate table rather than moving the catalog to a new location.
Responding as Docs Factory (V2): Open session · View in factory
There was a problem hiding this comment.
The bundled-skill table remains in the canonical Skill actions in conversation data section, and the skills page links directly there rather than duplicating it. Also clarified attribution at that source: exclude actions with input.bundled_skill_id, and count path-only loads as team-owned only after confirming the path belongs to a skill root the team manages. Included in 97a116ac.
| ## Filters in definitions as code | ||
|
|
||
| In a [factory definition](/factories/factory-as-code/), each entry under an automation's `triggers` takes an optional `filter` whose keys mirror the filters in the automation editor: | ||
| {/* VISUAL: An automation's trigger editor with More filters expanded. */} |
There was a problem hiding this comment.
why did we remove this in place of a visual?
There was a problem hiding this comment.
The VISUAL marker already existed and is a non-rendered comment, not a new screenshot. Default-automation guidance moved above the steps, and the definitions section retains the full PR example. The simpler labeled-issue example was removed but remains in the definition reference; a local example or direct link would preserve that introductory teaching.
Responding as Docs Factory (V2): Open session · View in factory
There was a problem hiding this comment.
Added explicit links to the canonical labeled-issue example and trigger-filter reference in Filters in definitions as code. The local pull-request example and default-automation guidance remain. The VISUAL marker was already present and does not replace the example; readers now have a direct route to the simpler labeled-issue example. Included in 97a116ac.
Correct factory permissions, validation coverage, completion guidance, and backend platform boundaries. Restore skill placement teaching, clarify usage attribution, and improve canonical links. Co-Authored-By: Warp <agent@warp.dev>
There was a problem hiding this comment.
Overview
Re-reviewed f8ef2e93: the four accuracy fixes and page-specific compression exceptions are verified. The agent-page split and restored skills tree preserve reader tasks and canonical ownership; the retained “About” titles are permitted, with one nonblocking screenshot-publication decision below.
Verdict
Checks: standard build and tests pass; CI red because automated-review publication failed with Argument list too long; visual proof present. That review reported no blocking findings, not a docs-build failure.
Review checks passed: links, navigation/anchors, redirects, generated headings, UI references, and risk/VERIFY accounting. Style scan: 160 advisory findings, not a clean lint pass; Trunk unavailable. Live factory setup, authentication, self-hosting, and billing were not exercised.
Found: 0 critical, 0 important, 1 suggestion, 0 nits.
Responding as Docs Factory (V2): Open session · View in factory
Summary
Clarify Warp's product entry points and factory workflows, reduce repetition, and make setup requirements easier to follow. This is an editorial review of existing documentation, not a new pricing or availability policy.
Changes
AGENTS.mdand the terminology glossary, and protect the agent-page routes with redirect regression tests.Review follow-up
Pushed in
97a116ac.Content design plan
Audience and task: Developers choosing a Warp product, starting a factory, or configuring its agents and infrastructure.
Content ownership: The agent concept page owns roles and human decision points; configuration owns existing-agent settings and authentication; creation owns custom roles and dispatch. Skills, automations, and definition syntax retain their respective procedures and references.
Editorial verdict: Preserve page purposes and useful setup context. Remove duplicate catalogs and repeated explanations, link their canonical owners, and retain old anchors when content moves. The agent split uses procedural pages; the conceptual titles remain “About factory agents” and “About factory infrastructure and security.”
Validation
The local review follow-up passed typecheck, heading-variable tests, the standard build, generated heading/TOC checks, homepage JSON-LD validation, UI-reference validation, whitespace checks, all six redirect tests, and an internal-link scan covering 4,469 links with zero broken links. Generated HTML confirms the skill tree stays inside step 2 of the four-step procedure. The three teaching-material pages pass compression checks and have no blocking style errors. Earlier checks confirmed the unchanged “About” titles and that the removed skill table exactly matches its linked API reference.
The earlier broader style scan reported 157 findings; it is not a clean style pass. Targeted checks covered the newly edited API reference as well. Trunk is unavailable. Existing build warnings include deprecated Astro settings, large chunks, the
/404route conflict, and Node 25/Vercel runtime fallback.CI, automated review, and Vercel are running on the new head (
97a116ac). For the previous head (bd3c6759), build/link-audit and Vercel passed; the reviewer reported a review-publication failure withArgument list too long, not a docs-build failure.Editorial exceptions
All reported overages already exist on the reviewed base (
df1cc389). Retain these pages for this scoped review rather than splitting or cutting necessary teaching to meet a count. Counts below exclude fenced code:agents/cli/quickstart.mdx: 874 words (base 887). Keep cross-platform installation, login, approvals, shell use, and resume guidance. Its three inherited callouts cover Homebrew updates, update controls, and headless credential handling; update guidance overlaps and remains a candidate for a CLI-focused cleanup.platform/integrations/quickstart.mdx: 678 words (base 664). Keep connection, authorization, first trigger, and run confirmation together; the added usage requirement explains funding without replacing the billing reference.platform/triggers/scheduled-agents-quickstart.mdx: 726 words (base 709). Keep run identity beside setup because it changes PR authorship and billing; preserve the first-run test and CLI limitation.quickstart.mdx: 758 words (base 760). Retain the continuous path from installation through Blocks, editing, completions, and the first agent conversation.factories/self-hosting/managed-kubernetes.mdx: 2,066 words (base 2,074). Retain Helm setup, RBAC, worker/task resource distinctions, secret injection, preflight limitations, disruption controls, and capacity guidance.factories/webhooks.mdx: 2,073 words (base 2,081). Retain authentication choices, setup, delivery confirmation, rotation, filtering, delivery rules, and recovery guidance.platform/integrations/github.mdx: 2,526 words (base 2,514). Retain team setup, per-user linking, thread continuation, installation-token permissions, and troubleshooting. Its three inherited callouts distinguish GitHub surfaces, the non-CLI setup path, and the installation-access security boundary.platform/harnesses/authentication.mdx: 817 words, unchanged. Keep its three inherited callouts distinguishing local BYOK, API funding versus a ChatGPT subscription, and the consequences of deleting credentials.These are scoped exceptions, not a claim that the pages have no further redundancy.
Screenshot publication exception
On 2026-10-16, Rachael approved retaining the documentation-repository names
docs-factory-configanddocs-internalinsrc/assets/factories/quickstart-connect-repo.pngandsrc/assets/factories/quickstart-factory-details.png. She considers these names non-sensitive and approved keeping the images unchanged. This exception is limited to publishing those repository names in these two screenshots; it does not change repository access or authorize publishing repository contents or credentials.Source verification
The four accuracy corrections were checked against:
Unverified claims
Live factory setup, third-party authentication, self-hosting, and billing were not exercised end to end. Earlier human team-switching and reviewer preview checks remain supporting evidence, not full workflow verification. Source revisions verify implementation or default instructions, not deployment or general availability.
Documentation risk
Risk: engineering-review-required
Rationale: Includes permissions, workflow/default behavior, configuration, credential boundaries, self-hosting, and platform-support claims. Page-specific compression exceptions are documented above.
Docs override: none
Agent context
Original review conversation · Continuation and review fixes · Approved agent-page split plan
Co-Authored-By: Warp agent@warp.dev