Skip to content

docs: audit Warp Factories launch readiness - #841

Merged
hongyi-chen merged 21 commits into
mainfrom
factory/factories-acquisition-ctas
Oct 6, 2026
Merged

hongyi-chen merged 21 commits into
mainfrom
factory/factories-acquisition-ctas

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR consolidates the Warp Factories launch-readiness audit into the existing acquisition-route change. It removes obsolete Early Access gating while retaining the navigation badge, aligns setup and configuration guidance with current implementation, and routes new users through one shared Warp onboarding URL.

Changes

  • Removed obsolete Early Access notices and access-request links while retaining the Early Access badge in the top navigation and Factories sidebar.
  • Documented team-level factory creation roles and per-factory User, Editor, and Admin permissions, benchmark harness selection, and configurable self-improvement thresholds and reviewer pools.
  • Reframed Jira around the normal connection path from setup or Integrations, with per-factory opt-in, automation configuration, testing, and delegated setup as a short fallback. Updated Microsoft Teams instructions for delegated setup and complete app upload and approval steps.
  • Corrected onboarding guidance so readers can choose Linear or Jira during factory setup.
  • Added VARS.GET_STARTED_URL and used it for the six acquisition links updated by this audit, including adjacent software-factory guides for readers who are not already in the product.
  • Replaced the Factories overview's generic button row with a responsive Starlight link-card grid that distinguishes prospective users from people creating or managing a factory.
  • Restored deployment safeguards in a concise checklist, separated factory roles from metering, clarified how factory Editors use existing team-level resources, and added curated security and infrastructure decision links.
  • Rechecked SDK names and self-hosting guidance against their current sources; no changes were needed.

Content design plan

  • Reader and job: A team admin or factory editor preparing Warp Factories for production use who needs accurate setup, permissions, integration, and configuration guidance.
  • Gap today: The docs still describe access gating and several pre-launch behaviors, which sends new users to obsolete request flows and omits shipped configuration paths.
  • Change: Correct the existing pages and navigation to describe current public behavior. Exclude self-hosting and SDK rewrites because those surfaces already match the shipped artifacts.

Unverified claims

None. Current UI labels, permissions, defaults, integration flows, and onboarding destinations were verified against implementation sources or the live route.

Documentation risk

Risk: engineering-review-required
Rationale: Changes public claims about Warp Factories availability, permissions, defaults, benchmark support, and Jira and Microsoft Teams integration setup.
Source files consulted: warp-server@625813ce9709a5bcddb0e71aa089e868426500ac (logic/factory_access.go, logic/factoryfile/self_improvement.go, logic/factoryfile/schema/v1alpha1/factory.schema.json, logic/ai/ambient_agents/benchmark_run_activities.go, logic/self_improvement_review_assignment.go, authz/agent_platform_policies.go, authz/types/subject_set.go, model/types/factory_user_roles.go, test/integration/factory_user_roles_test.go); warp-server@407ced43b39e94366d805e7a2c41fbce06cc5bb6 (logic/integration_setup.go, factorysource/defaults/automations.go, client/packages/factory/src/{components/integration-setup/SetupAdminChoice.tsx,pages/FactorySetup/steps/IssueTrackerStep.tsx,pages/FactorySetup/steps/jira-setup-instructions.tsx,pages/FactorySettings/JiraIntegrationConnect.tsx}); warp-server@5ecb1a5a128df55f380c78320c504a839908ce2e (logic/integration_setup_delegation.go, logic/integration_setup_jira.go, client/packages/factory/src/components/integration-setup/DelegateSetupForm.tsx, client/packages/factory/src/utils/integration-setup.ts); warp-server@f265476baab6c89fdff2a921e5fba45938641e33 (logic/integration_setup_microsoft_teams.go, client/packages/shared/src/components/ui/MicrosoftTeamsAppPackageInstructions.tsx); warp-server:client/packages/factory/src/pages/FactorySettings/TeamsIntegrationConnect.tsx@c20a44bef1f8fd25f66ece7c2fbd04b951ab1197
Requested engineering reviewers: none
Engineering review status: pending
Docs override: none

Verification

  • npm run build — passed at 7b5fb65b401f41bf14677c7d77bcc1ad9314cce8; Astro generated 393 Markdown documents.
  • Internal link validation — passed across 394 files and 4,294 links with no broken links.
  • UI-reference validation — passed for all 20 changed content files.
  • Compression checks — passed for the edited overview, quickstart, Microsoft Teams, Self-improvement, infrastructure and security, and Jira pages. The infrastructure and security page is 1,500 words and passes the feature-doc compression contract.
  • Style lint — completed for 20 files; 46 advisory findings remain, with no new blocker from this revision.
  • Acquisition-route check — https://www.warp.dev/get-started returns HTTP 200.
  • Exact-head visual verification — commit 7b5fb65b401f41bf14677c7d77bcc1ad9314cce8 renders the restored Early Access badge in the wide top navigation and mobile sidebar. The current CTA cards are side by side at 1300×800 and stacked at 375×812, with visible keyboard focus in light and dark themes and no clipping or horizontal overflow.
  • git diff --check origin/main...HEAD — passed.
  • trunk check — unavailable because Trunk is not installed in this environment.
Computer-use screenshots (10)

1. Light desktop (1300x800 viewport): top nav with Factories "Early Access" badge, page heading, both CTA cards with current descriptions.

  1. Light desktop (1300x800 viewport): top nav with Factories "Early Access" badge, page heading, both CTA cards with current descriptions.

2. Light desktop zoomed on top nav: Factories tab with "Early Access" pill badge, active underline, with Warp Factories overview heading for context.
2. Light desktop zoomed on top nav: Factories tab with "Early Access" pill badge, active underline, with Warp Factories overview heading for context.

3. Light desktop zoom of CTA cards showing current descriptions: "For prospective users and teams new to Warp Factories." and "For existing users and teams already using Warp Factories."
3. Light desktop zoom of CTA cards showing current descriptions: "For prospective users and teams new to Warp Factories." and "For existing users and teams already using Warp Factories."

4. Light desktop: keyboard focus ring on "Get started with Warp Factories"; status bar shows https://www.warp.dev/get-started (not clicked).
4. Light desktop: keyboard focus ring on "Get started with Warp Factories"; status bar shows https://www.warp.dev/get-started (not clicked).

5. Light desktop: keyboard focus ring on "Open Warp Factories"; status bar shows https://platform.warp.dev (not clicked).
5. Light desktop: keyboard focus ring on "Open Warp Factories"; status bar shows https://platform.warp.dev (not clicked).

6. Light mobile (375x812): CTA cards stacked vertically with current descriptions; no horizontal overflow (scrollWidth 360 = clientWidth 360).
6. Light mobile (375x812): CTA cards stacked vertically with current descriptions; no horizontal overflow (scrollWidth 360 = clientWidth 360).

7. Light mobile (375x812) nav drawer open: Factories entry (highlighted, active) with "Early Access" badge among Terminal, Agents, Automation Platform, etc.
7. Light mobile (375x812) nav drawer open: Factories entry (highlighted, active) with "Early Access" badge among Terminal, Agents, Automation Platform, etc.

8. Light mobile menu close-up: Factories "Early Access" badge fully visible between menu items Agents and Automation Platform (all 8 top-level entries shown).
8. Light mobile menu close-up: Factories "Early Access" badge fully visible between menu items Agents and Automation Platform (all 8 top-level entries shown).

9. Dark desktop (1300x800): "Early Access" badge on Factories nav tab, both CTA cards with current descriptions, keyboard focus ring on "Get started with Warp Factories".
9. Dark desktop (1300x800): "Early Access" badge on Factories nav tab, both CTA cards with current descriptions, keyboard focus ring on "Get started with Warp Factories".

10. Dark mobile (375x812) nav drawer open: Factories entry shows the "Early Access" badge among the top-level menu items.
10. Dark mobile (375x812) nav drawer open: Factories entry shows the "Early Access" badge among the top-level menu items.

Co-Authored-By: Oz oz-agent@warp.dev

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Oct 6, 2026
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 6, 2026 10:02pm UTC

Request Review

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@warp-agent-staging warp-agent-staging Bot added factory:docs-factory Label associated to the "docs-factory" factory warpy-factory Opened by the Warp factory agents labels Oct 6, 2026

@warp-agent-staging warp-agent-staging Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This change correctly routes prospective Factories CTAs to the requested launch URL, but human confirmation is needed because that destination is not live yet.

Concerns

  • https://www.warp.dev/get-started currently returns HTTP 404 after redirects, so merging before the landing page deploys would break every updated acquisition CTA. Keep this PR unmerged until the route serves successfully, or provide an alternate launch URL.

Verdict

Checks: build pass, tests pass, CI green, visual proof n/a

Found: 1 critical, 0 important, 0 suggestions, 0 nits

Responding as Docs Factory (V2): Open session · View in factory

Comment thread src/data/vars.ts
warp-agent-staging Bot and others added 2 commits October 6, 2026 16:37
Remove obsolete access gating and align setup, benchmark, and self-improvement guidance with current behavior.

Co-Authored-By: Oz <oz-agent@warp.dev>
Document self-improvement reviewer selection and the Factory User, Editor, and Admin permission boundaries.

Co-Authored-By: Oz <oz-agent@warp.dev>
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review October 6, 2026 17:48
@warp-for-oss

warp-for-oss Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

@warp-agent-staging[bot]

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/quickstart.mdx:20 — [IMPORTANT] The PR declares Risk: low, but replacing the Early Access 'Request access' path with a generic get-started link changes availability and access claims across 11 Warp Factories pages. The /get-started destination is unverified; the PR body says it returned 404, and the reviewer saw 200, but nothing shows it offers a Factories access path. Requested change: re-declare Risk: engineering-review-required with a rationale and source files or owner confirmation, or record a docs-verified override with evidence and the current head SHA. Update the 'Unverified claims' entry to the current 200 status.
  • src/content/docs/factories/how-factories-work.mdx:12 — [SUGGESTION] The note says Warp Factories is 'available to a limited set of teams. If your team is new to Warp Factories, get started with Warp Factories', which contradicts itself on access and repeats the product name. This sentence appears in 11 files. Requested change: reword once, for example 'If your team doesn't have access yet, get started with Warp Factories', and apply it consistently across all affected pages.
  • src/content/docs/factories/troubleshooting.mdx:19 — [SUGGESTION] The Cause says Warp Factories is enabled per team, but the Fix now points to a generic get-started page that does not enable an already-signed-up team. Requested change: state the concrete step that grants access and keep the 'ask a team admin to confirm' guidance.

Verdict

Request changes

@warp-for-oss warp-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR routes Warp Factories acquisition CTAs and related Warp account signup links through the shared GET_STARTED_URL constant, while preserving existing operational factory links. The changed docs use existing MDX variable patterns, the new URL target resolves successfully, and the attached spec context contains no approved commitments to validate against.

Concerns

  • No blocking concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

warp-agent-staging Bot and others added 3 commits October 6, 2026 18:07
Co-Authored-By: Oz <oz-agent@warp.dev>
Merge the reviewed launch-readiness audit into the acquisition CTA branch while retaining the shared get-started URL.

Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
@warp-agent-staging warp-agent-staging Bot changed the title docs: Route factory acquisition CTAs to get started docs: audit Warp Factories launch readiness Oct 6, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>
warp-agent-staging Bot and others added 3 commits October 6, 2026 19:04
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/index.mdx:19 — [IMPORTANT] The card description "Contact Warp to discuss your setup" does not match its link target, VARS.GET_STARTED_URL, which is the general onboarding page and not a contact or sales page. Requested change: describe the real destination (for example "For teams new to Warp. Create a Warp account and team.") or link to VARS.CONTACT_SALES_URL if a sales conversation is intended.
  • src/content/docs/factories/quickstart.mdx:16 — [IMPORTANT] "team admin or have editor permission for Warp Factories" conflicts with infrastructure-and-security.mdx, which defines User, Editor, and Admin as per-factory roles that cannot exist before a factory is created. The same claim appears in troubleshooting.mdx. Requested change: name the exact permission needed to create a factory and where an admin grants it, confirmed against logic/factory_access.go and authz/agent_platform_policies.go, use identical wording on both pages, and state that per-factory roles apply after creation.
  • src/content/docs/factories/integrations/teams.mdx:21 — [IMPORTANT] Step 3 says "follow the upload instructions" without saying where they are, after the explicit upload steps (Upload new app, upload the ZIP, approve it, then find Warp under Apps > Built for your org) were removed. Requested change: restore the concrete upload and approval steps, or link to the page or UI screen that contains them.
  • src/content/docs/factories/integrations/jira.mdx:22 — [SUGGESTION] "copy an approval link to send yourself" is ambiguous, and the step packs the whole delegated flow into one long paragraph. Requested change: reword to "copy an approval link and send it to a site admin yourself" and consider splitting the delegated path into its own short subsection.
  • src/content/docs/factories/integrations/teams.mdx:20 — [SUGGESTION] The PR deletes the "Who does each step" role overview and the "Use shared channels" and "Review results" bullets without mentioning it in the PR summary, even though delegated setup makes the overview more useful. Requested change: restore a shorter role overview, or explain the removal in the PR body, and confirm no page links to the removed content.
  • src/content/docs/factories/infrastructure-and-security.mdx:118 — [SUGGESTION] The page is 1,645 words against the 1,500-word feature-page budget and this paragraph adds a dense role description. The overage is justified in the PR body, so this does not block. Requested change: consider moving the User, Editor, and Admin role definitions to a short reference table or dedicated permissions section and trimming unrelated content to return the page to budget.

Verdict

Request changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/quickstart.mdx:16 — [IMPORTANT] The bullet calls Editor and User "team-level" Warp Factories roles, but infrastructure-and-security.mdx describes them as per-factory roles and troubleshooting.mdx says to ask an admin to grant editor permission. The linked section never says who can create a factory. Requested change: reconcile the three pages on whether the roles are team-level or per-factory, who can create a factory, and where an admin grants the role, and confirm against logic/factory_access.go and authz/agent_platform_policies.go.
  • src/content/docs/factories/integrations/jira.mdx:22 — [IMPORTANT] The delegated Jira setup claims (the "Someone else" option, emailed requests, seven-day links, and links that let the holder install and connect without your Warp session) include a security claim, and none of the cited Source files consulted cover Jira delegated setup. Requested change: cite the Jira source and commit you checked and add them to Source files consulted, or remove the claims you can't verify.
  • src/content/docs/factories/index.mdx:16 — [SUGGESTION] The card is titled "Get started with Warp Factories" and says "Contact Warp to discuss your setup", but it links to VARS.GET_STARTED_URL, the generic Warp get-started page. Requested change: reword the title and description to match the destination, or link VARS.CONTACT_SALES_URL if sales contact is intended.
  • src/content/docs/factories/integrations/teams.mdx:21 — [SUGGESTION] Step 3 packs about eight actions across Warp, Microsoft sign-in, and the Teams admin center, plus the delegated-recipient case, into one step, and the removed "Who does each step" list leaves out which role does what. Requested change: split the step into download, upload and approve, and a sentence for the delegated recipient, and keep a brief statement of who does each part.
  • src/content/docs/factories/infrastructure-and-security.mdx:118 — [SUGGESTION] The page is at 1645 words against the 1500-word feature-doc budget and the new roles paragraph adds to it. The PR body justifies the overage, so this does not block. Requested change: run a deletion-only pass on the roles paragraph, or move role definitions to a reference section if the page keeps growing.
  • src/content/docs/factories/measure-and-improve/self-improvement.mdx:14 — [SUGGESTION] The reviewer pools are described in prose but only the none and custom values are named. Requested change: name admins (the default) and team so readers can map the prose to factory.yaml, matching factory-as-code.mdx lines 242-244.
  • src/content/docs/factories/integrations/jira.mdx:22 — [NIT] "copy an approval link to send yourself" can be read as sending the link to yourself. Requested change: use "copy an approval link and send it to them yourself", as in the suggestion block.

Verdict

Request changes

Co-Authored-By: Oz <oz-agent@warp.dev>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/infrastructure-and-security.mdx:122 — [IMPORTANT] The hunk also deletes the seven-step "Deployment checklist", the guidance to "treat factory-definition changes as operational code", and the runner cross-links to /factories/runners/ and /factories/factory-as-code/#runnersnameyaml, none of which the PR body discloses (it calls the change a "targeted permissions correction"). Requested change: restore the checklist and operational-code guidance (or move them to a better home such as deployment-patterns.mdx), or list the removals with a reason in the PR body, and restore at least one runner-reference link.
  • src/data/vars.ts:70 — [IMPORTANT] GET_STARTED_URL (https://www.warp.dev/get-started) renders as "Get started with Warp Factories", a Factories lead form, but it replaces the generic https://www.warp.dev sign-up link in build-a-triage-agent.mdx:18, build-a-self-improving-agent.mdx:27, run-a-software-factory-in-the-cloud.mdx:20, and write-product-and-tech-specs-with-agents.mdx:21 under the link text "get started with Warp". Requested change: confirm the intended destination, and either keep the previous sign-up link in the non-Factories guides or use separately named variables for each destination.
  • src/content/docs/factories/infrastructure-and-security.mdx:112 — [SUGGESTION] quickstart.mdx:16 and troubleshooting.mdx:19 link to #governance-and-metering with the text "factory roles and team permissions", but that heading names governance and metering, not roles. Requested change: add a dedicated ## Factory roles and permissions heading, keep metering under its own heading, and update both anchors.
  • src/content/docs/factories/infrastructure-and-security.mdx:117 — [SUGGESTION] The Editor role is said to configure "integrations, secrets, MCP servers, and runners", while line 122 says creating or editing shared runners and connecting team-wide integrations remain team or workspace permissions. Requested change: reword the Editor bullet to the specific actions it permits (for example selecting runners and enabling connected integrations) and confirm against authz/agent_platform_policies.go.
  • src/content/docs/factories/infrastructure-and-security.mdx:125 — [NIT] Removing the checklist left two consecutive blank lines before ## Related pages (markdownlint MD012). Requested change: delete one blank line.
  • src/content/docs/factories/quickstart.mdx:16 — [SUGGESTION] The "Permission to create factories" prerequisite restates the role matrix owned by infrastructure-and-security.mdx, breaking say-it-once and lengthening the quickstart's prerequisites. Requested change: shorten it to the requirement plus a link to the roles section.
  • src/content/docs/factories/integrations/teams.mdx:20 — [SUGGESTION] The "Who does each step" list was removed and step ownership is now implicit ("you or a Teams admin", "the person completing setup") in a flow involving three people. Requested change: state the owner at the start of each step or restore a short roles list above the steps.
  • src/content/docs/factories/integrations/teams.mdx:38 — [SUGGESTION] The "Use shared channels" and "Review results" bullets were removed from "Start and continue work" although they are unrelated to delegated setup and not listed in the PR body. Requested change: restore both bullets, or document the removal and reason in the PR body.
  • src/content/docs/factories/benchmarks.mdx:66 — [SUGGESTION] The step says "choose the harness and model, or an authorized custom factory router" without naming the available harnesses or how a router interacts with harness selection, replacing the earlier "Third-party harness comparisons are not available yet" caveat. Requested change: name the harness options in the launch dialog, state whether a custom router applies to every harness, and confirm against benchmark_run_activities.go.
  • src/content/docs/factories/measure-and-improve/self-improvement.mdx:14 — [SUGGESTION] The new paragraph duplicates the failedRunThreshold range and reviewerType values already defined in the selfImprovement section of factory-as-code.mdx, which will drift. Requested change: keep one sentence naming selfImprovement.failedRunThreshold and reviewerType and link to the reference for values, defaults, and reviewerEmails.
  • src/content/docs/factories/integrations/jira.mdx:24 — [SUGGESTION] Steps 2 and 3 each pack several actions plus a side note (five pending-request actions in step 2, the warp-agent label caveat in step 3). Requested change: keep each step to its main action, move the pending-request management details to a note or troubleshooting bullet, and move the label-flow caveat out of step 3.

Verdict

Request changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/quickstart.mdx:16 — [IMPORTANT] The "team-level Warp Factories role" (Editor or User) conflicts with infrastructure-and-security.mdx, which describes User, Editor, and Admin as roles on a factory and never defines who may create one. troubleshooting.mdx ("grant you editor permission") adds a third framing. Requested change: confirm against logic/factory_access.go and authz/agent_platform_policies.go, then use one permissions model across quickstart.mdx, troubleshooting.mdx, and the Governance section, including who can create a factory and where an admin grants the role.
  • src/content/docs/factories/integrations/jira.mdx:22 — [IMPORTANT] "copy an approval link to send yourself" reads as sending the link to yourself, and the step packs the whole delegated flow into one paragraph. Requested change: replace with wording such as "to send to a site admin" and split the entry points, delegation path, and seven-day link behavior so the step is scannable.
  • src/content/docs/factories/integrations/jira.mdx:16 — [SUGGESTION] The prerequisite sentence "If you are not a site admin, you can send the setup to one instead." repeats the delegation guidance in step 1. Requested change: remove it or link to step 1 so the caveat appears once.
  • src/content/docs/factories/integrations/teams.mdx:21 — [SUGGESTION] Step 3 combines the download, a package-contents description, four Teams admin center actions, a confirmation, and the delegated-recipient path. Requested change: split the direct and delegated paths into separate steps and move the package-contents sentence out of the step.
  • src/content/docs/factories/integrations/teams.mdx:13 (removed lines) — [SUGGESTION] The PR deletes the "Who does each step" section and the "Use shared channels" and "Review results" bullets without mentioning it in the PR body, even though roles matter more with delegated setup. Requested change: restore them, or state in the PR body why they were cut and where the facts now live.
  • src/content/docs/factories/infrastructure-and-security.mdx:118 — [SUGGESTION] The roles paragraph keeps the page at 1,645 words against the 1,500-word feature-page budget; the PR body justifies the overage. Requested change: run a deletion-only pass on unrelated security guidance, or move the roles into a short reference section, before the page grows further.
  • src/content/docs/factories/index.mdx:19 — [SUGGESTION] The card text "Contact Warp to discuss your setup." links to VARS.GET_STARTED_URL, which quickstart.mdx and the guides describe as the self-serve way to create an account and team. Requested change: align the description with the destination (for example, "Create a Warp account and team to set up your first factory.") or use a sales URL if that is intended.

Verdict

Request changes

Restore concise deployment safeguards, separate team and factory role guidance, and clarify delegated Jira and Microsoft Teams setup responsibilities.\n\nCo-Authored-By: Oz <oz-agent@warp.dev>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/integrations/teams.mdx:13 — [IMPORTANT] The page is 1564 words against the 1500 feature-page budget with no justification, and the PR body claims the Teams page passed its compression check. Requested change: trim the page, for example by merging the direct and delegated variants in steps 5 and 6 and stating the expiry once, or justify the overage and correct the verification line in the PR body.
  • src/content/docs/factories/infrastructure-and-security.mdx:30 — [IMPORTANT] The change rewrites security and self-hosting prose in the data-boundary paragraph, the Runners section, and the managed self-hosting intro (it drops "so Warp still orchestrates their runs" and the "only the execution plane" framing). The PR body says self-hosting rewrites were excluded and needed no changes, and the cited sources don't cover them. Requested change: restore the original wording and keep the diff to the roles section, or update the PR body and cite supporting sources.
  • src/content/docs/factories/infrastructure-and-security.mdx:136 — [SUGGESTION] The Related pages links to Bring Your Own LLM, Enterprise security overview, and Team-managed model keys and endpoints were removed without relation to this PR. Requested change: restore them.
  • src/content/docs/factories/infrastructure-and-security.mdx:110 — [SUGGESTION] The new "Factory roles and permissions" section dropped the link to the team roles page and adds to a page already over its word budget. Requested change: link to /enterprise/team-management/roles-and-permissions/ and consider moving the roles content to its own page.
  • src/content/docs/factories/integrations/jira.mdx:57 — [SUGGESTION] The claims about adding recipients, resending or revoking links, and resetting your own link aren't in the cited sources, while Unverified claims says None. The expiry note also trails the test step. Requested change: cite the source or remove the clauses, and move the expiry note next to step 2.
  • src/content/docs/factories/benchmarks.mdx:12 — [SUGGESTION] The intro now says model, harness, and runner configurations, but benchmarks.mdx:4 and :92, measure-and-improve.mdx:49 and :82, and factory-dashboard.mdx:74 still say model and runner. Requested change: update those references for consistency.
  • src/content/docs/factories/index.mdx:17 — [SUGGESTION] The card titled "Get started with Warp Factories" links to the generic Warp /get-started page, and "Enter your work email to continue" describes a third-party page verified only by HTTP 200. Requested change: retitle the card to match the destination or describe only what the page is.
  • src/content/docs/factories/measure-and-improve/self-improvement.mdx:14 — [SUGGESTION] This restates the 1-50 range, the reviewerType values, and the default of 25 failures, which factory-as-code.mdx already documents (the 25-failure default is not there). Requested change: keep one sentence and link to the reference so the values don't drift.

Verdict

Request changes

Co-Authored-By: Oz <oz-agent@warp.dev>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/infrastructure-and-security.mdx:120 — [SUGGESTION] The roles sentence is awkward, and no page says where the team-level role is set even though the quickstart and troubleshooting pages send readers here. Requested change: rewrite as "Factory Admins manage its roles. Team and workspace admins manage the team-level Warp Factories role," and name the settings location once.
  • src/content/docs/factories/infrastructure-and-security.mdx:131 — [SUGGESTION] "Choose execution and inference hosts" is ambiguous, and the Bring Your Own LLM and Enterprise security overview links were dropped from Related pages. Requested change: reword the checklist item to "Choose where execution runs and which inference provider is used," restore the two Related pages links, and link the team roles page from the roles section.
  • src/content/docs/factories/integrations/jira.mdx:57 — [SUGGESTION] The setup-link expiry and pending-request paragraph, and the warp-agent label caveat at line 59, trail the procedure and are detached from steps 2 and 3. Requested change: move the expiry and management sentence into step 2 or a short subsection after step 3, and place the label caveat beside the platform guide link in step 3.
  • src/content/docs/factories/integrations/teams.mdx:27 — [SUGGESTION] Step 3 no longer names the download control and mixes the delegated path into the direct path. Requested change: name the button that downloads the package, and move the delegated-recipient notes in steps 3 and 6 to step 2 where the approval link is introduced.
  • src/content/docs/factories/measure-and-improve/self-improvement.mdx:14 — [SUGGESTION] The paragraph restates the selfImprovement settings already owned by factory-as-code.mdx, and "randomly requests one eligible reviewer" isn't stated there. Requested change: shorten it to one sentence naming selfImprovement.failedRunThreshold and reviewerType with a link to the reference, and add the reviewer-selection behavior to the reference if it is correct.
  • src/content/docs/index.mdx:34 — [NIT] With the Early Access sentence removed, the Warp Factories section opens with "A factory turns..." without naming the product. Requested change: start with "Warp Factories turns incoming engineering work into a repeatable, multi-stage workflow with specialized agents, review points, and measurable outcomes."

Verdict

Approve with nits

warp-agent-staging Bot and others added 2 commits October 6, 2026 20:04
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/integrations/jira.mdx:24 — [IMPORTANT] Steps 2 and 3 apply only to the 'Someone else' branch but are numbered unconditionally after step 1's 'If you are a Jira site admin, continue directly', so a site admin following in order is told to send the setup to someone else. Requested change: prefix steps 2-3 with a condition, state which step a direct site admin continues from, move the seven-day expiry paragraph (line 57) next to step 2, and move the warp-agent label caveat (line 59) next to the platform Jira setup link in step 3.
  • src/content/docs/factories/integrations/teams.mdx:30 — [IMPORTANT] Step 6 combines the direct and delegated paths without naming who acts ('Back in setup, select and connect the team. A delegated recipient uses the approval link; direct setup requires a workspace admin...'), step 3 has the same ambiguity ('A delegated recipient uses the approval link without your Warp session'), and the earlier note that Warp connects a pending team automatically during factory setup was dropped. Requested change: split direct and delegated actions into separate sentences naming the actor, and restore or intentionally remove the automatic-connection note.
  • src/content/docs/factories/infrastructure-and-security.mdx:112 — [SUGGESTION] 'Team and workspace admins and team-level Editors can create factories' is hard to parse and 'Editor' names both a team-level and a per-factory role. Requested change: name the 'team-level Warp Factories Editor role' once and state where an admin assigns it (also referenced without a location in quickstart.mdx and troubleshooting.mdx).
  • src/content/docs/factories/infrastructure-and-security.mdx:131 — [SUGGESTION] The compressed deployment checklist drops inference routing, runner/definition configuration, and specification review, says 'Choose execution and inference hosts' (inference is routed to a provider, not hosted by the factory), and the edit removed the Bring Your Own LLM and Enterprise security overview Related pages links. Requested change: restore the inference item, correct the wording, and restore those two links.
  • src/content/docs/factories/measure-and-improve/self-improvement.mdx:14 — [SUGGESTION] The new paragraph repeats the selfImprovement field list owned by factory-as-code.mdx, and it is unclear whether 'For a GitHub-backed factory' limits only the threshold or the reviewer settings. Requested change: cut to one sentence plus the link and state the scope once.
  • src/content/docs/factories/quickstart.mdx:11 — [SUGGESTION] The opening 'Create a factory and take one small work item from prompt to pull request in about 10 minutes.' no longer states the audience or assumed knowledge, and 'Available team usage' (line 17) is vague. Requested change: restore one sentence stating who the quickstart is for and that readers already know which repositories to use, and rename the prerequisite 'Team credits'.
  • src/content/docs/factories/index.mdx:17 — [SUGGESTION] The card titled 'Get started with Warp Factories' links to the generic https://www.warp.dev/get-started page, and the PR only verified HTTP 200. Requested change: confirm the destination leads to Factories or retitle the card (for example 'Get started with Warp').
  • src/content/docs/factories/index.mdx:19 — [SUGGESTION] The PR body's 'Exact-head visual check' claims captures remain valid for head 3a550b6 because index.mdx did not change, but head 63e09a0 changed both card descriptions and the screenshot captions show the old text. Requested change: update the Verification section to the current head and refresh or drop the stale captures.
  • src/content/docs/factories/integrations/jira.mdx:57 — [SUGGESTION] 'copy or reset your own link' does not say what resetting does or where the control is, and the seven-day expiry and recipient-management claims could not be confirmed against the cited warp-server sources. Requested change: name the action and its location or drop the clause, and have Docs validate these claims before merge.

Verdict

Request changes

warp-agent-staging Bot and others added 2 commits October 6, 2026 20:08
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • src/content/docs/factories/benchmarks.mdx:12 — [SUGGESTION] The intro now says benchmarks compare model, harness, and runner configurations, but the frontmatter description (line 4), the "Factory default" bullet (line 31), and the closing guidance (line 92) still say only models and runners. Requested change: update those to match, and note that third-party harnesses need a paid plan, as factory-agents.mdx does.
  • src/content/docs/factories/integrations/jira.mdx:25 — [SUGGESTION] The unindented paragraph "If you aren't a Jira site admin..." splits the numbered list, so step 3 starts a new list. Line 23 also gives the path as Apps > Manage apps > Warp > Configure, while platform/integrations/jira.mdx says to open the three-dot actions menu and click Configure. Requested change: indent the paragraph under step 2 or fold it into the step text, and use one Configure path in both pages.
  • src/content/docs/factories/integrations/teams.mdx:30 — [SUGGESTION] Steps 3 to 6 mix the direct and delegated flows, so the reader can't tell which actions they perform. Step 6 reads "A delegated recipient uses the approval link; direct setup requires a workspace admin...", and line 16 says the "Teams admin or team owner" both adds the app and that "A Teams admin uploads and approves it". Requested change: split the delegated path into its own short subsection, or label each step with who performs it.
  • src/content/docs/factories/infrastructure-and-security.mdx:30 — [SUGGESTION] The deleted sentence introduced the self-hosted data boundaries diagram on line 32 and said factory runs follow the same data model. The image now follows the links with no lead-in. Requested change: restore one short sentence before the image, such as "The diagram shows these boundaries for self-hosted execution; factory runs follow the same data model."
  • src/content/docs/factories/measure-and-improve/self-improvement.mdx:14 — [SUGGESTION] This paragraph repeats the failedRunThreshold, reviewerType, and reviewerEmails values already listed under selfImprovement in factory-as-code.mdx. Requested change: keep one sentence naming the threshold and reviewer pool settings and link to that reference, so the values live in one place.
  • src/content/docs/factories/quickstart.mdx:11 — [SUGGESTION] The opening paragraph "Create a factory and take one small work item from prompt to pull request in about 10 minutes." no longer says who the quickstart is for or what it assumes. The deleted sentence said readers should know which repositories the factory will use. Requested change: add one clause naming the audience and that assumption.

Verdict

Approve with nits

@hongyi-chen
hongyi-chen merged commit b43e00b into main Oct 6, 2026
11 of 12 checks passed
@hongyi-chen
hongyi-chen deleted the factory/factories-acquisition-ctas branch October 6, 2026 22:10
hongyi-chen added a commit that referenced this pull request Oct 6, 2026
Tighten the opening (drop "tools your team already uses"), make the
component headings parallel, say "repeated failures" consistently, and
note that benchmarks now compare harnesses as well as models and runners
per #841.

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
hongyi-chen added a commit that referenced this pull request Oct 7, 2026
* docs: rewrite the Warp Factories overview copy

Reshape the factories overview from a launch-post structure into a
technical overview: a concrete definition up front, one short section
per part of a factory, sizing guidance, and related pages. Removes the
"Who benefits", "What you get", product-table, and "Key terms" sections
and the undefined "delivery policy" coinage. The #sizing-a-factory
anchor that three pages link to is preserved.

Aligns the opening definition on how-factories-work and the docs
homepage with the overview, trims the diagram legend, cuts the salesy
self-improvement framing, and adds the missing Related pages section.

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

* docs: review pass on the factories overview after merging main

Tighten the opening (drop "tools your team already uses"), make the
component headings parallel, say "repeated failures" consistently, and
note that benchmarks now compare harnesses as well as models and runners
per #841.

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

* docs: address independent review on the factories overview

Add Microsoft Teams and Azure DevOps to the how-factories-work work
sources legend so it matches the overview, and drop the restated
consequence clause from the overview's Execution section in favor of
naming what the infrastructure page covers.

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

* docs: rewrite the Enterprise overview copy

Same treatment as the factories overview: a concrete opener, three
short lists of what Enterprise adds (administration, security and
compliance, shared team configuration), role-based entry points, and
related pages. Removes the "Who Warp Enterprise is for", "What this
section covers", "Why enterprises choose Warp", and "Support and
resources" sections and the marketing adjectives. Every retained claim
was checked against the enterprise page it links to.

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

* Revert "docs: rewrite the Enterprise overview copy"

This reverts commit ff03ffb.

* docs: give the factories overview a heading above the fold

Shorten the lead to two sentences, keep the CTA cards directly under it,
and open a "What a factory does" section for the foreman, example, and
human-checkpoint detail so the body is not an unbroken block of prose
before the first H2. Rewrite the description so it stops repeating the
lead paragraph it renders next to.

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

---------

Co-authored-by: Warp <agent@warp.dev>
Co-authored-by: Oz <oz-agent@warp.dev>

This branch was successfully deployed

1 active deployment
Preview — 7e644551 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed factory:docs-factory Label associated to the "docs-factory" factory warpy-factory Opened by the Warp factory agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant