fix(table): fix stack list silent crash on null resource_control#4
Open
FAZuH wants to merge 1 commit into
Open
fix(table): fix stack list silent crash on null resource_control#4FAZuH wants to merge 1 commit into
FAZuH wants to merge 1 commit into
Conversation
aab792c to
8eb4c33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrpt stack listsilently fails and results in empty output if there exists a stack with nullStackList::resource_control.This PR:
ResourceControltoOption<ResourceControl>so the command does not fail silently.serde_json::Value::Nullinto an empty string to prevent the value showing asnull."ResourceControl": nullin the API response correctly deserializes toStackListwithresource_control: Nonerather than crashing.Note that
Stackinsrc/commands/stacks/models/deploy.rsdoes not need any changes since theresource_controlis alreadyOption<ResourceControl>