Skip to content

Require system focus for gamepad user gesture #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nondebug wants to merge 6 commits into
base: gh-pages
Choose a base branch
from
Open

Require system focus for gamepad user gesture #207

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3488c7c
Require system focus for gamepad user gesture
nondebug May 10, 2024
9c81ec4
Add missing steps in getGamepads
nondebug May 10, 2024
cc058cd
Chore(README.md): remove link to old features (#208)
marcoscaceres Aug 9, 2024
3b8d37e
Require system focus for gamepad user gesture
nondebug May 10, 2024
f65d469
Merge branch 'gh-pages' into gesture-requires-focus
marcoscaceres Feb 13, 2026
6903dc6
Add null check, remove duplicate step
nondebug Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,8 +801,15 @@ <h3>
<li>Let |navigator:Navigator| be |gamepad|'s [=relevant global
object=]'s {{Navigator}} object.
</li>
<li>Let |document:Document?| be |gamepad|'s [=relevant global
object=]'s [=associated `Document`=]; otherwise `null`.
Copy link
Copy Markdown
Member

@marcoscaceres marcoscaceres Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the document is null then that's exceptional... InvalidStateError?

Copy link
Copy Markdown
Collaborator Author

@nondebug nondebug Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't make sense to throw here because we're inside "When the system receives new button or axis input values", if we throw an error there's nothing to catch it.

Copy link
Copy Markdown
Member

@marcoscaceres marcoscaceres Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point. Yes, it should just return gracefully.

</li>
<li>If |document| is `null`, abort these steps.
</li>
<li>If |navigator|.{{Navigator/[[hasGamepadGesture]]}} is `false` and
|gamepad| [=contains a gamepad user gesture=]:
|document| is a [=Document/fully active descendant of a top-level
traversable with user attention=] and |gamepad| [=contains a gamepad
Copy link
Copy Markdown
Collaborator

@gabrielsanbrito gabrielsanbrito Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create an alias for "focused"?

"A [=Document=] |document| is focused if |document| is a [=Document/fully active descendant of a top-level traversable with user attention=] and |gamepad| [=contains a gamepad user gesture=]:"?

Copy link
Copy Markdown
Member

@marcoscaceres marcoscaceres Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we should do that, to be honest. If we need the concept of focus, we should link out to HTML (which defines it).

user gesture=]:
Comment on lines +810 to +812
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition uses “|document| is a Document/fully active descendant …” but |document| is defined as Document? and can be null. Add an explicit |document| is not null (or change the condition to handle null) before applying the HTML definition, to avoid a type-mismatched check and make the focus requirement unambiguous.

Suggested change
|document| is a [=Document/fully active descendant of a top-level
traversable with user attention=] and |gamepad| [=contains a gamepad
user gesture=]:
|document| is not `null` and is a [=Document/fully active descendant
of a top-level traversable with user attention=] and |gamepad|
[=contains a gamepad user gesture=]:

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@marcoscaceres marcoscaceres Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yeah... maybe this check should also happen earlier. If you don't have a document anyway, then none of the above really matters, right?

<ol>
<li>Set |navigator|.{{Navigator/[[hasGamepadGesture]]}} to
`true`.
Expand All @@ -818,10 +825,6 @@ <h3>
<li>Set |connectedGamepad|.{{Gamepad/[[timestamp]]}} to
|now|.
</li>
<li>Let |document:Document?| be |gamepad|'s [=relevant
global object=]'s [=associated `Document`=]; otherwise
`null`.
</li>
<li>If |document| is not `null` and is [=Document/fully
active=], then [=queue a global task=] on the [=gamepad
task source=] to [=fire an event=] named
Expand Down
Loading