Fix: Handle missing Graphiti compose file gracefully during restart#379
Open
Priyanka-2725 wants to merge 1 commit into
Open
Fix: Handle missing Graphiti compose file gracefully during restart#379Priyanka-2725 wants to merge 1 commit into
Priyanka-2725 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Problem
When running
./installer restartwithGRAPHITI_ENABLED=falsein.env, the installer fails with:This occurs because:
Solution
Added a two-layer defensive approach for handling missing compose files:
Layer 1: Existing check -
composeFileExists()returns early if file doesn't existLayer 2 (NEW): Added error handling that catches "file does not exist" errors from the actual operation and treats them as success (skip gracefully)
Key changes:
isComposeMissingError()helper function to detect missing file errors by checking error messagesperformStackOperation()to catch and handle missing file errors gracefully for optional stacksstringsimport for error message parsingCloses #378
Type of Change
Areas Affected
Testing and Verification
Test Configuration