Skip to content

update: post created card token endpoint EDU-18858 - #1760

Merged
ricardoaerobr merged 9 commits into
masterfrom
EDU-18858---POST-Create-Card-token-endpoint-update
Aug 26, 2026
Merged

update: post created card token endpoint EDU-18858#1760
ricardoaerobr merged 9 commits into
masterfrom
EDU-18858---POST-Create-Card-token-endpoint-update

Conversation

@ricardoaerobr

Copy link
Copy Markdown
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • Not yet, but I'm going to.
  • No, it's just a fix.

@ricardoaerobr ricardoaerobr self-assigned this Aug 24, 2026
@ricardoaerobr ricardoaerobr added the documentation Improvements or additions to documentation label Aug 24, 2026
@vtex-pr-sentinel

Copy link
Copy Markdown

🛡️ SDD Check — action required

I couldn't detect an SDD in this PR. Please check one option below (requires write access to the repo):

  • SDD lives in another PR — paste the SDD PR URL here:
  • This PR doesn't need an SDD
  • SDD applies, but I'm not adopting it in this PR

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

OpenAPI Preview

Preview the changed specs:

Links point to commit 5cb3be8. They will update on each new push to this PR.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution. The .json file will be checked now with Spectral.

@PedroAntunesCosta

Copy link
Copy Markdown
Contributor

Now that Create card token's 201 documents a full response body, Update card token's 201 (same status code, same resource) still has no content. Out of scope for this PR, but worth a follow-up ticket for consistency. Not blocking, but I think it's worth flagging it here.

@PedroAntunesCosta

Copy link
Copy Markdown
Contributor

Spectral lint comparison against master: 38 issues on both sides, none added or removed by this PR (pre-existing status-code-descriptions-format, request-example-parallel-to-schema, and no-chained-refs-in-components findings are unrelated to these changes). Not blocking, but I think you should consider addressing these issues shortly.

@ricardoaerobr

Copy link
Copy Markdown
Contributor Author

Spectral lint comparison against master: 38 issues on both sides, none added or removed by this PR (pre-existing status-code-descriptions-format, request-example-parallel-to-schema, and no-chained-refs-in-components findings are unrelated to these changes). Not blocking, but I think you should consider addressing these issues shortly.

Thanks for checking this. I reproduced the comparison and confirmed that the 38 Spectral findings are pre-existing and unchanged by this PR. I’ll create a follow-up task to address them separately, keeping this PR focused on documenting the Create card token response.

@ricardoaerobr

Copy link
Copy Markdown
Contributor Author

Now that Create card token's 201 documents a full response body, Update card token's 201 (same status code, same resource) still has no content. Out of scope for this PR, but worth a follow-up ticket for consistency. Not blocking, but I think it's worth flagging it here.

Yes. I confirmed with the requester that it will be addressed further after further discussions with the Payment team.

@ricardoaerobr
ricardoaerobr merged commit 80e9c24 into master Aug 26, 2026
1 of 2 checks passed
@ricardoaerobr
ricardoaerobr deleted the EDU-18858---POST-Create-Card-token-endpoint-update branch August 26, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants