Skip to content

Revert "Add comment showing change in benchmark file sizes (#7264)"#7286

Merged
connortsui20 merged 1 commit intodevelopfrom
ct/revert-7264
Apr 3, 2026
Merged

Revert "Add comment showing change in benchmark file sizes (#7264)"#7286
connortsui20 merged 1 commit intodevelopfrom
ct/revert-7264

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

This reverts commit 16bbd12.

Seems to be breaking when on develop, but not on the branch?

This reverts commit 16bbd12.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 requested review from AdamGS and a10y April 3, 2026 22:33
@connortsui20 connortsui20 added the changelog/skip Do not list PR in the changelog label Apr 3, 2026
@connortsui20 connortsui20 enabled auto-merge (squash) April 3, 2026 22:33
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 3, 2026

Merging this PR will degrade performance by 29.87%

⚡ 1 improved benchmark
❌ 8 regressed benchmarks
✅ 1113 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.05)] 381 µs 424.2 µs -10.19%
Simulation take_map[(0.1, 0.5)] 974 µs 1,209.5 µs -19.48%
Simulation take_map[(0.1, 1.0)] 1.6 ms 2.3 ms -29.87%
Simulation patched_take_10k_random 242.6 µs 273 µs -11.13%
Simulation patched_take_10k_contiguous_patches 229.9 µs 260.2 µs -11.67%
Simulation take_10k_dispersed 242.5 µs 287.4 µs -15.63%
Simulation patched_take_10k_first_chunk_only 304.7 µs 274.4 µs +11.02%
Simulation take_10k_first_chunk_only 227.9 µs 272.7 µs -16.46%
Simulation patched_take_10k_contiguous_not_patches 230.2 µs 260.6 µs -11.64%

Comparing ct/revert-7264 (83f7d33) with develop (c1b9223)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 merged commit e3c7401 into develop Apr 3, 2026
111 of 116 checks passed
@connortsui20 connortsui20 deleted the ct/revert-7264 branch April 3, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants